One-PR stack: submit reports success, but merge says the stack was not submitted
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Accessibilité débutants
- 76/100
Piste de recherche
Commencez dans cmd/submit.go en lisant syncStack et son appelant, puis comparez la vérification du remote-stack dans cmd/merge.go. Reproduisez le flux one-PR avec les commandes de l’issue ; c’est terminé lorsque submit signale correctement le remote-stack manquant et que merge fournit un résultat exploitable ou la commande suivante, sans demander à l’utilisateur de répéter une soumission réussie.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Summary
A local stack can contain one branch and one pull request. gh stack submit reports success for this stack:
✓ Pushed and synced 1 branches
However, GitHub does not create a remote stack object. A remote stack requires at least two pull requests.
gh stack merge then rejects the local stack:
✗ this stack has not been submitted to GitHub yet; run `gh stack submit` first
A second gh stack submit does not fix the problem. It reports success again.
Reproduction
- Create a branch from the trunk branch.
- Commit a change on the new branch.
- Initialize a local stack that contains only the new branch.
- Run
gh stack submitand create the pull request. - Run
gh stack submitagain. - Run
gh stack merge --squash.
Example output:
$ gh stack submit
Checking stack state...
Pushing to origin...
PR #30 for close-clinkr-cli-entry-point is up to date
✓ Pushed and synced 1 branches
$ gh stack sync
✓ Fetched latest main from origin
✓ Trunk main is already up to date
Pushing 1 branch to origin...
✓ Pushed 1 branches
Syncing PRs ...
✓ PR #30 (close-clinkr-cli-entry-point) — Open
✓ Branches synced
Stacked on main (69c442c)
$ gh stack merge --squash
✗ this stack has not been submitted to GitHub yet; run `gh stack submit` first
The pull request exists and is open. In this reproduction, GitHub also reported the pull request as mergeable and clean.
Expected behavior
The commands should not give conflicting results.
gh stack submit should state that it published a regular pull request but did not create a remote stack object. Alternatively, it should explain that a remote stack requires at least two pull requests.
gh stack merge should handle a local stack with one pull request. It can merge the pull request directly, or it can show an actionable command such as gh pr merge.
Actual behavior
gh stack submit reports that it pushed and synchronized the one-branch stack. It exits successfully.
gh stack merge reports that the same stack was not submitted. It tells the user to repeat the command that already reported success.
Source context
The behavior is also present on the current github/gh-stack main branch at commit ab00aa4a3f2dddc51aa65849c68b391a1b079311.
In cmd/submit.go, syncStack returns false when the stack has fewer than two pull requests:
// The API requires at least 2 PRs to form a stack.
if len(prNumbers) < 2 {
return false
}
The caller does not use this result:
if stacksAvailable {
syncStack(cfg, client, s)
clearPendingModifyState(cfg, gitDir)
}
The command then prints the success message:
cfg.Successf("Pushed and synced %d branches", len(s.ActiveBranches()))
In cmd/merge.go, the merge command requires a remote stack ID or number:
if s.ID == "" && s.Number == 0 {
cfg.Errorf("this stack has not been submitted to GitHub yet; run `gh stack submit` first")
return nil, ErrNotInStack
}
Thus, the submit command knows that it did not create a remote stack object. However, it discards that result and reports success.
Environment
gh stack version 0.1.0
Darwin 25.6.0 arm64
Deviations: none.
- Langage dominant
- Go
- Étoiles
- 1.5k
- Forks
- 73
- Merge moyen
- 1 j 8 h
- PR mergées (30 j)
- 7
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de github/gh-stack
-
Difficulté 2/5 1-3 heures Accessibilité débutants 85/100
-
Difficulté 1/5 Moins d'une heure Accessibilité débutants 92/100
-
feature request topic: cli - general
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
-
feature request topic: auto-merge
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
-
bug topic: docs
Difficulté 1/5 Moins d'une heure Accessibilité débutants 68/100
Toutes les issues de github/gh-stack
Issues similaires
-
Difficulté 1/5 Moins d'une heure Accessibilité débutants 60/100
github/gh-aw-mcpg#13748 ·
-
agentic-workflows
Difficulté 2/5 1-3 heures Accessibilité débutants 65/100
-
needs-triage
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 65/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
googleapis/librarian#7670 · 2 commentaires ·