One-PR stack: submit reports success, but merge says the stack was not submitted
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 76/100
Línea de trabajo
Empieza en cmd/submit.go leyendo syncStack y su invocador; después compara la comprobación del remote-stack en cmd/merge.go. Reproduce el flujo de one-PR con los comandos del issue; se considera terminado cuando submit informa correctamente del remote-stack que falta y merge proporciona un resultado utilizable o el siguiente comando, sin indicar al usuario que repita un envío correcto.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
A local stack can contain one branch and one pull request. gh stack submit reports success for this stack:
✓ Pushed and synced 1 branches
However, GitHub does not create a remote stack object. A remote stack requires at least two pull requests.
gh stack merge then rejects the local stack:
✗ this stack has not been submitted to GitHub yet; run `gh stack submit` first
A second gh stack submit does not fix the problem. It reports success again.
Reproduction
- Create a branch from the trunk branch.
- Commit a change on the new branch.
- Initialize a local stack that contains only the new branch.
- Run
gh stack submitand create the pull request. - Run
gh stack submitagain. - Run
gh stack merge --squash.
Example output:
$ gh stack submit
Checking stack state...
Pushing to origin...
PR #30 for close-clinkr-cli-entry-point is up to date
✓ Pushed and synced 1 branches
$ gh stack sync
✓ Fetched latest main from origin
✓ Trunk main is already up to date
Pushing 1 branch to origin...
✓ Pushed 1 branches
Syncing PRs ...
✓ PR #30 (close-clinkr-cli-entry-point) — Open
✓ Branches synced
Stacked on main (69c442c)
$ gh stack merge --squash
✗ this stack has not been submitted to GitHub yet; run `gh stack submit` first
The pull request exists and is open. In this reproduction, GitHub also reported the pull request as mergeable and clean.
Expected behavior
The commands should not give conflicting results.
gh stack submit should state that it published a regular pull request but did not create a remote stack object. Alternatively, it should explain that a remote stack requires at least two pull requests.
gh stack merge should handle a local stack with one pull request. It can merge the pull request directly, or it can show an actionable command such as gh pr merge.
Actual behavior
gh stack submit reports that it pushed and synchronized the one-branch stack. It exits successfully.
gh stack merge reports that the same stack was not submitted. It tells the user to repeat the command that already reported success.
Source context
The behavior is also present on the current github/gh-stack main branch at commit ab00aa4a3f2dddc51aa65849c68b391a1b079311.
In cmd/submit.go, syncStack returns false when the stack has fewer than two pull requests:
// The API requires at least 2 PRs to form a stack.
if len(prNumbers) < 2 {
return false
}
The caller does not use this result:
if stacksAvailable {
syncStack(cfg, client, s)
clearPendingModifyState(cfg, gitDir)
}
The command then prints the success message:
cfg.Successf("Pushed and synced %d branches", len(s.ActiveBranches()))
In cmd/merge.go, the merge command requires a remote stack ID or number:
if s.ID == "" && s.Number == 0 {
cfg.Errorf("this stack has not been submitted to GitHub yet; run `gh stack submit` first")
return nil, ErrNotInStack
}
Thus, the submit command knows that it did not create a remote stack object. However, it discards that result and reports success.
Environment
gh stack version 0.1.0
Darwin 25.6.0 arm64
Deviations: none.
- Lenguaje dominante
- Go
- Estrellas
- 1.5k
- Forks
- 73
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 7
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de github/gh-stack
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
-
feature request topic: cli - general
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
feature request topic: auto-merge
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
bug topic: docs
Dificultad 1/5 Menos de una hora Aptitud para principiantes 68/100
Todos los issues de github/gh-stack
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
NVIDIA/gpu-operator#2955 ·
-
agentic-workflows
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
Broadcast Documentation Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
kovidgoyal/kitty#10516 ·
-
CVE-2024-24786 CPE mismatch Abiertobug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
cisagov/vulnrichment#337 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100