Migrate to hardened docker images
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 52/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- docker, node.js, typescript
Research direction
Start with the private mirrors Dockerfile and inspect how the npm script currently launches the app and where the transpiled JavaScript is produced. Review the simple-git usage and test the image build and runtime behavior with Docker Hardened Images for Node.js. Done means the image uses the hardened base, launches the transpiled JavaScript directly with node, and retains the dependencies needed by simple-git.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem?
The current docker images used by private mirrors contain many dependencies that are unnecessary to the functioning of the app and present a vulnerability risk.
Describe the solution you'd like
Docker published Docker Hardened Images for Node.js that should reduce the number of unnecessary dependencies in the private mirrors images.
Describe alternatives you've considered
Alternatively the current private mirrors Dockerfile could have logic added to remove unnecessary dependencies but this has the risk of not being thorough or unintentionally breaking things.
Additional context
As part of this change the Dockerfile will need to be updated to not use an npm script as the final command in favor of directly executing the transpiled Javascript with node. There may also be complications due to the use of simple-git in private mirrors which will require testing to ensure that the new images still have the necessary dependencies.
- Dominant language
- TypeScript
- Stars
- 203
- Forks
- 42
- Avg merge
- 1h 15m
- Merged PRs (30d)
- 8
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github-community-projects/private-mirrors
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
github-community-projects/private-mirrors#525 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
github-community-projects/private-mirrors#524 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-2 days Newbie friendliness 68/100
github-community-projects/private-mirrors#449 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 45/100
github-community-projects/private-mirrors#485 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
github-community-projects/private-mirrors#481 ·
Maintainers usually reply within 1 day
All issues in github-community-projects/private-mirrors
Similar issues
-
no-repo-link tool-submission
Difficulty 1/5 Under an hour Newbie friendliness 66/100
BraveOPotato/NoSignups#2458 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
drmrd/vernacular#1061 ·
Maintainers usually reply within 1 day
-
[Bug] PUT /profiles/{id} silently drops design_prompt — designed voice profiles cannot be editedOpen
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
automated issue report
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
eventua11y/eventua11y.com#982 ·
Maintainers usually reply within 1 day