Show a success message after deleting a mirror
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- next.js, typescript
- Domain
- frontend
Research direction
Start in src/app/[organizationId]/forks/[forkId]/page.tsx and follow how create/edit set and clear their success flash state through closeAllFlashes. Read handleOnDeleteMirror and deleteMirror to see where success is known, and only show the delete flash on success rather than refetching after an error. For the numberOfMirrorsOnPage === 1 case, replace window.location.reload() with navigating to the previous page so the flash survives. Done means deleting a mirror shows the same green confirmation as create/edit, including when it was the last mirror on the page.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem?
Creating or editing a mirror shows a green success flash ("You have successfully created/updated…"), but deleting one shows nothing. The mirror just disappears from the list, or the page reloads if it was the last mirror on the page, so it's unclear whether the delete succeeded.
Describe the solution you'd like
Show a SuccessFlash after a successful delete, e.g. "You have successfully deleted mirror <org>/<name>.", consistent with create and edit:
- Add delete success flash state alongside the create/edit ones in
src/app/[organizationId]/forks/[forkId]/page.tsxand close it incloseAllFlashes - Only show it when
deleteMirrorsucceeds. TodayhandleOnDeleteMirrorrefetches even after an error. - Handle the
numberOfMirrorsOnPage === 1path, wherewindow.location.reload()would wipe the flash (e.g. go to the previous page instead of reloading)
Describe alternatives you've considered
Leaving it as is. The list refresh is the only confirmation today.
Additional context
Noticed while testing create/edit/delete for #521. Not a regression: delete has never had a success message.
- Dominant language
- TypeScript
- Stars
- 203
- Forks
- 42
- Avg merge
- 1h 15m
- Merged PRs (30d)
- 8
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github-community-projects/private-mirrors
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
github-community-projects/private-mirrors#524 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-2 days Newbie friendliness 68/100
github-community-projects/private-mirrors#449 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 45/100
github-community-projects/private-mirrors#485 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
github-community-projects/private-mirrors#481 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
github-community-projects/private-mirrors#476 · 1 reaction ·
Maintainers usually reply within 1 day
All issues in github-community-projects/private-mirrors
Similar issues
-
[MCP]: page snapshots in .playwright-mcp/ are not git-ignored (.playwright-cli/ is, since #42318)Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
microsoft/playwright#44289 ·
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 Half a day Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
blamechris/chroxy#9272 ·
Maintainers usually reply within 1 day
-
no-repo-link tool-submission
Difficulty 1/5 Under an hour Newbie friendliness 66/100
BraveOPotato/NoSignups#2458 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
drmrd/vernacular#1061 ·
Maintainers usually reply within 1 day