with_child_span drops spans when blocks exit via break, return, or throw
Maintainers usually reply within 2 days
@itsrayeedscodespace is already working on this.
Since Nov 14, 2026.
- #3207 by @itsrayeedscodespace — open
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- ruby
- Domain
- observability
Research direction
Start in the SDK's Span#with_child_span, where finish runs after yield and in the rescue branch, and in the public wrapper on the Sentry module that delegates to it. Read the existing specs around span finishing and the transaction event's span filtering to confirm an unfinished span is dropped. The fix is to finish the child span in an ensure while keeping the StandardError handling and the direct return value, then run the span specs plus the four reproduction cases (break, nonlocal return, catch/throw, custom Exception).
Written by the indexing model from the issue text.
Description
Issue Description
Sentry.with_child_span silently loses its child span when the block exits via break, a nonlocal return, or throw. The same happens when the block raises an exception outside StandardError.
The underlying Span#with_child_span calls finish after yield and in its rescue branch. None of those paths run for nonlocal control flow. The hub restores the parent scope in ensure, but the child still has a nil timestamp, so TransactionEvent filters it out of the captured transaction.
Reproduction Steps
On current master (314eacad), with Ruby 3.4.12:
require "sentry-ruby"
Sentry.init do |config|
config.dsn = "http://public@localhost/1"
config.transport.transport_class = Sentry::DummyTransport
config.background_worker_threads = 0
config.traces_sample_rate = 1.0
end
transaction = Sentry.start_transaction(name: "repro", sampled: true)
Sentry.get_current_scope.set_span(transaction)
result = Sentry.with_child_span(op: "work") { break :done }
transaction.finish
p result # :done
p Sentry.get_current_client.transport.events.last.spans # []
A method returning from inside the span block, catch/throw, and a raised custom Exception subclass all produce the same missing span. Four public-API regression specs reproduce this on unchanged master.
Expected Behavior
The child span is finished and included in the transaction regardless of how control leaves the block. Return values and exception propagation remain unchanged.
Actual Behavior
The child span is unfinished and silently excluded from the captured transaction.
Proposed Fix
Finish the child span in an ensure block around the yield. Keep the existing StandardError handling and direct Span#with_child_span return value.
- Dominant language
- Ruby
- Stars
- 990
- Forks
- 552
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 29
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getsentry/sentry-ruby
-
Bug Ruby
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
getsentry/sentry-ruby#3211 · 1 comment ·
Maintainers usually reply within 2 days
-
Events dropped client-side for size are only logged at debug level and not recorded as lostPossibly taken @sentry-junior claimed this today. OpenBug Junior: repro Ruby
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
getsentry/sentry-ruby#3209 · 2 comments · 1 reaction ·
Maintainers usually reply within 2 days
-
Let apps choose how the client IP on events is determinedPossibly taken @sl0thentr0py claimed this 11 days ago. OpenImprovement Ruby
getsentry/sentry-ruby#3180 · 2 comments · 1 reaction · 1 assignee ·
Maintainers usually reply within 2 days
-
breaking change Next Major
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
getsentry/sentry-ruby#3176 · 1 comment ·
Maintainers usually reply within 2 days
-
With `register_error_subscriber`, view errors are reported twice: the wrapper by the middleware, and its cause by the error subscriberPossibly taken @sl0thentr0py claimed this 13 days ago. OpenBug Ruby
Difficulty 4/5 1-2 days Newbie friendliness 57/100
getsentry/sentry-ruby#3166 · 1 comment · 1 assignee ·
Maintainers usually reply within 2 days
All issues in getsentry/sentry-ruby
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
internetee/registry#2984 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ecosyste-ms/issues#862 ·
Maintainers usually reply within 1 day
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configuredPossibly taken @mimosa claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
riscv/riscv-unified-db#2829 ·
Maintainers usually reply within 1 day
-
⛓️ Security Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
rubyforgood/casa#7404 ·
Maintainers usually reply within 1 day