Don't double instrument when using instrumented Ktor client with OkHttp engine
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
The issue names the Ktor client integration, OkHttp engine, SAGP auto-instrumentation, and bytecode manipulation, but no files, tests, or entry points. Start by tracing these instrumentation paths and determine whether calls can be detected as doubly instrumented; done means preventing duplicate instrumentation without breaking standalone OkHttp instrumentation.
Written by the indexing model from the issue text.
Description
Problem Statement
We're about to release a Ktor client integration for sentry-java.
If a customer uses Ktor client with our integration, OkHttp as the engine for Ktor client, and SAGP with auto-instrumentation for OkHttp, they will end up with doubly instrumented HTTP calls.
While we're going to document very clearly that they should instrument either one or the other, users might still run into this.
There might be a way to detect if calls are being doubly instrumented and deactivate one of the two instrumentations.
Solution Brainstorm
I'm not sure if this is possible in the first place. The bytecode manipulation code would basically have to detect whether OkHttp is running inside Ktor or on its own.
- Dominant language
- Kotlin
- Stars
- 184
- Forks
- 41
- Avg merge
- 2d 10m
- Merged PRs (30d)
- 20
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getsentry/sentry-android-gradle-plugin
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
getsentry/sentry-android-gradle-plugin#1454 · 1 comment ·
Maintainers usually reply within 1 day
-
Android Improvement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
getsentry/sentry-android-gradle-plugin#1369 · 1 comment ·
Maintainers usually reply within 1 day
-
Android good first issue Improvement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
getsentry/sentry-android-gradle-plugin#1266 · 1 comment ·
Maintainers usually reply within 1 day
-
Android Feature Waiting for: Community
Difficulty 4/5 3-5 days Newbie friendliness 45/100
getsentry/sentry-android-gradle-plugin#1406 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Task
Difficulty 4/5 3-5 days Newbie friendliness 45/100
getsentry/sentry-android-gradle-plugin#1354 · 1 comment ·
Maintainers usually reply within 1 day
All issues in getsentry/sentry-android-gradle-plugin
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
recloudstream/cloudstream#3226 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
aws/aws-crt-kotlin#309 ·
Maintainers usually reply within 3 days
-
OAI-PMH
Difficulty 2/5 1-3 hours Newbie friendliness 78/100