Tags should be stored on a per-Person basis

Open
#57 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend, databases

Research direction

Begin by locating the PatchTag and the Patch, CoverLetter, Tag, and Person models, then trace how tags are stored for submissions. Clarify whether the model should become SubmissionTag and define the Person association; done means duplicate handling and cover-letter tagging follow the agreed behavior.

Written by the indexing model from the issue text.

Description

enhancement

At present, a PatchTag contains three fields:

  • A link to the Patch
  • A link to the Tag
  • A count of the number of Tags stored against this Patch

This works, but it's not ideal:

  • Duplicated tags are possible, as we treat all tags the same
  • Tags cannot be associated with the other type of Submission, namely CoverLetter

We should change how we store PatchTags to include the Person, if any, that was associated with this patch. We may also take the opportunity to change this model to a SubmissionTag, such that cover letters can have tags stored against them. This would allow us to set tags on all patches if a tag is submitted against a cover letter.

Dominant language
Python
Stars
317
Forks
91
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from getpatchwork/patchwork

All issues in getpatchwork/patchwork

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.