Ignore whitespace before and after git tags

Open
#645 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
git, python
Domain
cli, tooling

Research direction

Start with the pwclient git-am entry point and reproduce the reported patch using the whitespace-padded Reviewed-by tag shown in the issue. Determine whether tag parsing belongs to patchwork or pwclient, then verify that git-am preserves the tag and that tags without surrounding whitespace continue to work.

Written by the indexing model from the issue text.

Description

NOTE: Experienced on old 2.2.0, maybe it has been fixed. Also I'm not sure if it is patchwork or pwclient issue.

Space before git tags (e.g. Reviewed-by: Li Wang <liwang@redhat.com>) causes pwclient git-am to ignore them.

See:
https://lore.kernel.org/ltp/CAEemH2dU6XP+Er75eERgo+p7TyMgEjMJY7tjAGA15NOKFrZM+A@mail.gmail.com/
https://patchwork.ozlabs.org/project/ltp/patch/20251010113014.309433-1-pvorel@suse.cz/#3595268

$ cat ~/.pwclientrc
[ozlabs]
url = https://patchwork.ozlabs.org/xmlrpc/
username: ...
password: ...

$ pwclient git-am 2148087 -p ozlabs
Applying patch #2148087 using "git am"
Description: tst_cmd.h: Convert the rest of comments to kerneldoc
Applying: tst_cmd.h: Convert the rest of comments to kerneldoc

$ git log -1
commit 980c30ad8042de6694be88866a0d668aa8748bc9 (HEAD -> xxx)
Author: Petr Vorel <pvorel@suse.cz>
Date:   Fri Oct 10 13:30:14 2025 +0200

    tst_cmd.h: Convert the rest of comments to kerneldoc
    
    Move docs from the private function implementations (functions with
    trailing underscore) to functions used into functions used in the new
    API.
    
    This avoids to document private functions.
    
    Signed-off-by: Petr Vorel <pvorel@suse.cz>
    Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

=> There is no Reviewed-by: Li Wang <liwang@redhat.com>.

Dominant language
Python
Stars
317
Forks
91
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from getpatchwork/patchwork

All issues in getpatchwork/patchwork

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.