docs: ci-workflows says a same-repo PR runs its own e2e gate action
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, shell
- Domain
- ci-cd, documentation
Research direction
Read the “Validating gate changes” section in docs/contributing/ci-workflows.md and compare its explanation with the checkout behavior added in #9246. Reword the paragraph to clarify that same-repository PRs use their own e2e.yml, while the gate action and script come from the base revision; mention validation with scripts/check-e2e-authorization-test.sh and after merge. Done when the documentation matches that behavior.
Written by the indexing model from the issue text.
Description
Problem
docs/contributing/ci-workflows.md, "Validating gate changes", says a same-repository pull_request run takes e2e.yml and the gate action from the PR merge ref, so a gate-modifying PR exercises its own gate. After #9246 the gate job checks out github.event.pull_request.base.sha before calling ./.github/actions/check-e2e-authorization, so the action and scripts/check-e2e-authorization.sh come from the base commit. Only the workflow definition comes from the merge ref.
Fix
Reword the paragraph: a same-repository PR exercises its own e2e.yml, but the gate action and script run at the base revision, so changes to them are validated by scripts/check-e2e-authorization-test.sh and after merge.
Raised in review on #9246.
- Dominant language
- Go
- Stars
- 146
- Forks
- 112
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 358
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fullsend-ai/fullsend
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
fullsend-ai/fullsend#9404 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
fullsend-ai/fullsend#9371 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
fullsend-ai/fullsend#9278 ·
Maintainers usually reply within 1 day
-
question
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
fullsend-ai/fullsend#9251 · 4 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
fullsend-ai/fullsend#9237 ·
Maintainers usually reply within 1 day
All issues in fullsend-ai/fullsend
Similar issues
-
0.kind: bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Tnsor-Labs/brokoli#1029 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Judgment-Pack/judgment-pack-runtime#390 ·
Maintainers usually reply within 1 day
-
triage/needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
cozystack/cozystack#5300 · 1 reaction ·
Maintainers usually reply within 2 days
-
bug go
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
teradata-labs/loom#665 ·
Maintainers usually reply within 1 day