dialect check refuses a pack that declares Core 0.5.0

Open Beginner friendly
  • Is something wrong?
#390 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
go
Domain
cli

Research direction

Find the dialect check path that rejects unsupported specVersion values and the sdk.Load doc comment. Read the existing dialect check tests first, then add a test using a 0.5.0 pack with a value set and an annotation. Done when the check reads its fact and evidence inventory and the comment lists the supported version.

Written by the indexing model from the issue text.

Description

bug

Observed. jpack dialect check d.json --pack p.json with a pack that declares specVersion 0.5.0 answers JPS-SURFACE-SPEC-VERSION-UNSUPPORTED and names 0.1.0-draft, 0.2.0-draft and 0.3.0 only. The same pack declared 0.3.0 is checked. Ordinary validation and evaluation read 0.5.0 since v0.44.0.

Also: the doc comment on sdk.Load names 0.2.0-draft and 0.3.0 only, though it admits 0.5.0.

Ask. dialect check reads a 0.5.0 pack's fact and evidence inventory, value sets included; the comment is corrected.

Acceptance. A test with a 0.5.0 pack that uses a value set and an annotation.

Dominant language
Go
Stars
2
Forks
6
Avg merge
2h 1m
Merged PRs (30d)
69

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Judgment-Pack/judgment-pack-runtime

All issues in Judgment-Pack/judgment-pack-runtime

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.