propsHistory
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- javascript
Research direction
Start in src/core/modules/router/swipe-back.js around line 265, then compare the swipe-back flow with the router.back() behavior described in the issue. Use the provided CodeSandbox to reproduce navigation with route props. Done means swipe-back removes the corresponding propsHistory entry and no longer corrupts subsequent route props.
Written by the indexing model from the issue text.
Description
- Framework7 version: 9.0.0
- Platform and Target: core/vue/react/svelte
- codesandbox: https://codesandbox.io/p/devbox/gallant-jennings-dks7cn
Describe the bug
keep router props history if page was loaded with passed props.
it was fixed here: https://github.com/framework7io/framework7/commit/5ad3d8a995ab303a76c0f50ceae58af39426c8dd (committed on Jan 20, 2023)
but it is still a bug when user swipe-back.
in other words: when user "go back" (router.back()), everything is ok (namely: router.propsHistory.pop();).
but when user swipe-back "it" doesn't "pop" propsHistory (which will cause a mess in route-props).
all we need is this line: router.propsHistory.pop(); (or router.propsHistory.length = router.history.length)
exactly right after this line: https://github.com/framework7io/framework7/blob/3408af380c4f4252deff791e8421ae73d7afd5d6/src/core/modules/router/swipe-back.js#L265
- Dominant language
- JavaScript
- Stars
- 18.8k
- Forks
- 3.2k
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from framework7io/framework7
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
framework7io/framework7#4365 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
framework7io/framework7#4222 · 3 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
framework7io/framework7#4175 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
framework7io/framework7#3969 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
framework7io/framework7#3922 · 5 comments ·
All issues in framework7io/framework7
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·