month picker/year picker bug in calendar
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 64/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- javascript
- Domain
- mobile
Research direction
Reproduce the issue in the provided CodeSandbox using the sheet modal calendar, then locate the monthPicker/yearPicker done-button implementation and inspect its sheet-close behavior. The fix is complete when Done closes only the picker popover while leaving the sheet modal calendar open; repeat the listed reproduction steps on Framework7 8.3.0.
Written by the indexing model from the issue text.
Description
- Framework7 version: 8.3.0
- Platform and Target: Cordova Android & ios
- Live Link or CodeSandbox: PREFERABLY (IF YOU WANT YOUR ISSUE TO BE RESOLVED ASAP). You can start from forking the following CodeSandbox template: CodeSandbox
Describe the bug
If you press the "done" button on the monthPicker&yearPicker in the sheet modal calendar, the sheet will be closed.
To Reproduce
Steps to reproduce the behavior:
- Open sheet modal calendar
- Click on monthPicker or yearPicker
- Click the “done” button
- closed sheet modal calendar
Expected behavior
The popover should close.
Actual Behavior
The sheet modal calendar closes.
Additional context
You need to remove the "sheet-close" class from the "done" button.
- Dominant language
- JavaScript
- Stars
- 18.8k
- Forks
- 3.2k
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from framework7io/framework7
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
framework7io/framework7#4365 · 1 comment ·
-
propsHistory Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
framework7io/framework7#4347 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
framework7io/framework7#4175 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
framework7io/framework7#3969 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
framework7io/framework7#3922 · 5 comments ·
All issues in framework7io/framework7
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·