[Intervention] error in console on 'touchmove' - Color Picker

Open Beginner friendly
#3,922 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
javascript
Domain
frontend

Research direction

Start in color-picker/modules/wheel.js at line 106 and reproduce the warning by swiping a Color Picker in the Cordova or Chrome setup. Verify that the touchmove interaction still works and that the console no longer reports the non-cancelable event warning.

Written by the indexing model from the issue text.

Description

Framework7 version: 6.0.22
Platform and Target:Cordova app + Chrome browser

Describe the bug

An error occurred when swipe a Color Picker

[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

To Reproduce

Steps to reproduce the behavior:
Create a Color Picker and swipe

Screenshots

Schermata 2021-07-19 alle 15 09 27

Additional context

To solve the problem please change " e.preventDefault(); " with:
if (e.cancelable) {
e.preventDefault();
}
at line 106 of the "color-picker/modules/wheel.js" file

Dominant language
JavaScript
Stars
18.8k
Forks
3.2k
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from framework7io/framework7

All issues in framework7io/framework7

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.