squad cast can't add a second member with the same role: the provenance "rename" heuristic matches on the exact role string

Ouverte
#2,524 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
node.js, typescript

Piste de recherche

Start with packages/squad-sdk/src/casting/agent-provenance.ts around reconcileAgentProvenanceRegistry and the roleHints check, then trace how packages/squad-cli/src/cli/commands/cast.ts calls it. Check the cast command tests for repeated roles and rename behavior. Done means a new member can share an existing role without being mistaken for a rename, with the command’s rename behavior defined explicitly.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Version: CLI built from release/prepare-2.0.0-preview.5 @ 38d45d02 (package version 2.0.0-preview.6).

What happens

Casting a second member whose role string equals an existing active member's role is rejected:

D=$(mktemp -d); cd "$D"; git init -q
node <squad-cli>/dist/cli-entry.js init --roles --client copilot,claude
node <squad-cli>/dist/cli-entry.js cast --name Alpha --role "Test Engineer"   # ✓
node <squad-cli>/dist/cli-entry.js cast --name Beta  --role "Test Engineer"   # ✗
AgentProvenanceError: New agent id "beta" ambiguously resembles existing role owner(s) alpha; supply the existing stable id for a rename

Teams with two or more people in the same role (two Test Engineers, two Backend Engineers) can't be cast with squad cast. The only workaround is to invent a distinct role string for each member. This failure also leaves partial state behind; that's #2525.

Why it looks wrong

  • The docblock on reconcileAgentProvenanceRegistry says identity binds only through the explicit id: "Display name, role, labels, paths, and other incidental signals never establish identity." The roleHints check makes role establish (suspected) identity anyway.
  • The hint can't be followed from the CLI. squad cast derives the id from --name, and it has no way to "supply the existing stable id for a rename." Renaming Alpha to Beta and adding Beta as a new member look identical, so the heuristic blocks the add.

Expected

Adding a member with a new id and a new display name always adds a member, even when its role matches someone else's. A rename should be explicit, for example squad cast --rename <existing-id> --name <new-name>, or a dedicated squad rename. That would supply the existing id to reconcileAgentProvenanceRegistry. The ambiguity check could be dropped, or turned into an informational note ("Alpha already holds Test Engineer; adding Beta as a second one").

Source

  • packages/squad-sdk/src/casting/agent-provenance.ts, lines 1194–1203 (if (!previous) { const roleHints = ... record.role === role ...; throw ... }). The docblock contradicting it is at lines 1142–1148.
  • packages/squad-cli/src/cli/commands/cast.ts: updateCastingStateWithAgent (line 295) passes one candidate { id: slug, displayName, role, universe: 'cli-cast' } and has no rename input.

🤖 Generated with Claude Code

Langage dominant
TypeScript
Étoiles
3.4k
Forks
516
Merge moyen
1 j 15 h
PR mergées (30 j)
116

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de github/squad

Toutes les issues de github/squad

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.