bug(cli): standalone doctor checks unrelated application node_modules instead of active runtime
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 48/100
- Type d'issue
- Bug
- Clarté
- Clairement spécifiée
- Activité
- Active
- Stack technique
- node.js, typescript
Piste de recherche
Start with packages/squad-cli/src/cli/commands/doctor.ts, especially checkVscodeJsonrpcExports(cwd) and checkCopilotSdkSessionPatch(cwd), then trace how the invoked CLI resolves its runtime dependencies. Add coverage for a standalone installation with healthy dependencies and an unrelated empty application node_modules, plus a genuinely broken runtime. Done means doctor reports the runtime actually in use and retains warnings for real import failures.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Summary
Windows standalone Squad 2.0.0-preview.2 reports missing dependency/patch warnings based on the application's node_modules, even when the standalone installation's actual runtime dependencies import successfully.
An unrelated application's node_modules changes the advice to "run npm install or check dependencies". Following that advice in the application would not repair the runtime Squad is actually using.
This is distinct from the missing/broken package cases in #449 and #1190: both dependencies are healthy in the standalone runtime here. It also reproduces the confusing installed-user warning pattern previously reported in #565.
Synthetic reproduction
- Use the Windows standalone
2.0.0-preview.2distribution. - Create a synthetic application directory with an empty
node_modulesdirectory and a minimal.squad/team.md. Do not install Squad into that application. - Call the installed CLI's exported
runDoctor(syntheticApplicationDirectory); inspect these two result records:
[
{
"name": "vscode-jsonrpc exports field",
"status": "warn",
"message": "not found in node_modules — run npm install or check dependencies"
},
{
"name": "copilot-sdk session.js ESM patch",
"status": "warn",
"message": "not found in node_modules — run npm install or check dependencies"
}
]
- Separately import
vscode-jsonrpc/noderesolved relative to the standalone application'spackage.json, and import that installation's@github/copilot-sdk/dist/session.js.
Observed: both imports succeed. The same warning pair is observable from native standalone squad doctor in an application with unrelated dependencies.
The synthetic probe uses no real team files, credentials, or application data.
Source evidence
packages/squad-cli/src/cli/commands/doctor.ts:
checkVscodeJsonrpcExports(cwd)checks only<cwd>/node_modules/...and<cwd>/packages/squad-cli/node_modules/....checkCopilotSdkSessionPatch(cwd)has the same scope.- An existing
<cwd>/node_modulesis treated as a Squad development context, although it can belong entirely to the host application.
These lookups and warning messages are also present in current upstream dev at the time of this report.
Expected
Check or clearly identify the runtime actually used by the invoked Squad installation. Distinguish:
- application-local Squad dependencies genuinely in use;
- standalone/global runtime dependencies;
- an unrelated application dependency directory;
- an unverified runtime.
Do not recommend installing or patching application dependencies solely because the standalone runtime is outside the current checkout. Retain real failures for malformed exports or actual runtime import errors; an unknown lookup should not silently become success.
Suggested coverage: standalone/global installation with healthy dependencies plus an unrelated application's empty node_modules, and a separate genuinely broken runtime case.
Local handling
The warning scope and successful standalone imports are recorded separately. No application dependency was installed and no vendor source or export map was patched to silence diagnostics.
- Langage dominant
- TypeScript
- Étoiles
- 3.4k
- Forks
- 516
- Merge moyen
- 1 j 15 h
- PR mergées (30 j)
- 116
Préparer son environnement
- Fournit un Dockerfile ou un fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de github/squad
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 84/100
Les mainteneurs répondent en général sous 1 jour
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 77/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de github/squad
Issues similaires
-
bot:ai-assisted component:platform-js status:untriaged
Difficulté 1/5 Moins d'une heure Accessibilité débutants 74/100
midnightntwrk/platform-js#38 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
ranxianglei/billion-context#7068 ·
Les mainteneurs répondent en général sous 1 jour
-
vendor: bump whisper.cpp past 6a8addd — the current pin aborts the app on a failed Metal initOuverte
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
mybigday/whisper.rn#348 ·
-
enhancement severity:low
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
Battle-Cattle/BCUK-Bot-4#1075 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 67/100
ilan-pinto/roaring-lions#1552 ·
Les mainteneurs répondent en général sous 1 jour