Align hiring flow and routing templates with squad health validation

Ouverte
#2,234 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
45/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
github, typescript
Domaine
cli, devtools

Piste de recherche

The report identifies squad init and add-member guidance, routing templates, and the squad health validator, but names no files or tests. Start by locating those entry points and tracing how routing targets are generated and checked against registry IDs. Done means hiring guidance creates valid routing targets, excludes unsupported agents, and requires a passing health check before declaring a team ready.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

wave:2-soon

Steps

  1. delete old squad from repo
  2. squad init
  3. ask for new team, let it run
  4. run squad health, fail
  5. ask squad to fix it, many times

Friction report

I asked for a Squad health check and for the team-hiring process to be fixed. The first response changed the default naming guidance but did not make the resulting team pass squad health. After I separately asked to run the check, it failed on routing references. The next response added a health gate to the init instructions but still left the current health failure unresolved, so I had to ask twice for the correction. I also had to separately ask for squad health to be run.

The eventual fix aligned routing targets with registry IDs and removed built-in support agents from routing destinations. squad health then passed.

Root cause

The hiring/routing guidance and health validator disagreed: routing examples used display names (for example, Nick Fury), while the validator resolves registry IDs (for example, nick-fury). Built-in support agents such as Rai and Fact Checker are not cast registry agents and should not be routing targets. The hiring flow also lacked a required health check before declaring a team ready.

Expected behavior

  • Init and add-member guidance generates routing entries using the canonical agent IDs the health check accepts.
  • Support agents that are not valid routing targets are not added to the routing table.
  • Hiring is not reported complete until squad health passes; failures are diagnosed and fixed rather than merely reported.

Related: #1605 (squad health readiness check command).

Langage dominant
TypeScript
Étoiles
3.4k
Forks
516
Merge moyen
1 j 15 h
PR mergées (30 j)
116

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de github/squad

Toutes les issues de github/squad

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.