chore: migrate call sites off the deprecated feature aliases (tokio-runtime, embassy-runtime, critical-section-std-impl)

Ouverte
  • Quelque chose ne va pas ?
#458 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
55/100
Type d'issue
Refactorisation
Clarté
Clairement spécifiée
Activité
Active
Stack technique
rust
Domaine
build-system, developer-experience

Piste de recherche

Start by checking each listed Makefile, Cargo.toml manifest, and example call site to identify which crate receives each feature; the issue warns that the same names are valid features on the adapter crates. Replace deprecated connector aliases with the canonical features and check for remaining in-tree uses. Then decide whether aliases should be removed now or retained for one release cycle with a CHANGELOG note.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

enhancement

Problem

The connector crates keep feature aliases that their own docs call deprecated:

  • aimdb-mqtt-connector/src/lib.rs:21 — "tokio-runtime: deprecated alias for std"
  • aimdb-knx-connector/src/lib.rs:22-23 — "tokio-runtime and embassy-runtime are deprecated aliases for std and connector respectively, and critical-section-std-impl a deprecated …"
  • aimdb-tcp-connector/Cargo.toml:35-36 — tokio-runtime = ["std"], embassy-runtime = ["connector"]
  • aimdb-websocket-connector/Cargo.toml:31-33 — tokio-runtime = ["server"], kept for existing users

But the repository itself is still the main consumer of those aliases, so they cannot be removed:

  • Makefile: e.g. lines 156, 297, 428, 432, 440, 452–454, 476, 502, 521, 655–675 pass tokio-runtime, embassy-runtime or critical-section-std-impl to connector crates.
  • Manifests: aimdb-client/Cargo.toml:44, aimdb-bench/Cargo.toml:103, aimdb-knx-connector/Cargo.toml:74, aimdb-mqtt-connector/Cargo.toml (84, 104–107, 125–133, 209), tools/embedded-check-fixture/Cargo.toml:33.
  • Examples: tokio-mqtt-connector-demo, tokio-knx-connector-demo, remote-access-demo, sync-api-demo, and the embassy demos.

(tokio-runtime on aimdb-tokio-adapter and embassy-runtime on aimdb-embassy-adapter are real features of those crates, not aliases — those uses are fine and out of scope.)

Suggested work

  1. Replace alias uses on the connector crates with the canonical features (std, connector, server) in the Makefile, crate manifests and examples.
  2. Once nothing in-tree uses them, decide on removal: delete in the next breaking release, or keep for one more cycle with a CHANGELOG note.
  3. aimdb-knx-connector's critical-section-std-impl = [] is already an empty feature and can go as soon as its callers are updated.

Notes

Found by grep over manifests, Makefile and workflows at d9c7be0. Each call site needs a check of which crate the feature is being passed to before editing, because the same names are legitimate on the adapter crates.

Langage dominant
Rust
Étoiles
101
Forks
20
Merge moyen
2 h 33 min
PR mergées (30 j)
90

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de aimdb-dev/aimdb

Toutes les issues de aimdb-dev/aimdb

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.