chore: migrate call sites off the deprecated feature aliases (tokio-runtime, embassy-runtime, critical-section-std-impl)

Abierto
  • ¿Algo no está bien?
#458 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
build-system, developer-experience

Línea de trabajo

Start by checking each listed Makefile, Cargo.toml manifest, and example call site to identify which crate receives each feature; the issue warns that the same names are valid features on the adapter crates. Replace deprecated connector aliases with the canonical features and check for remaining in-tree uses. Then decide whether aliases should be removed now or retained for one release cycle with a CHANGELOG note.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Problem

The connector crates keep feature aliases that their own docs call deprecated:

  • aimdb-mqtt-connector/src/lib.rs:21 — "tokio-runtime: deprecated alias for std"
  • aimdb-knx-connector/src/lib.rs:22-23 — "tokio-runtime and embassy-runtime are deprecated aliases for std and connector respectively, and critical-section-std-impl a deprecated …"
  • aimdb-tcp-connector/Cargo.toml:35-36 — tokio-runtime = ["std"], embassy-runtime = ["connector"]
  • aimdb-websocket-connector/Cargo.toml:31-33 — tokio-runtime = ["server"], kept for existing users

But the repository itself is still the main consumer of those aliases, so they cannot be removed:

  • Makefile: e.g. lines 156, 297, 428, 432, 440, 452–454, 476, 502, 521, 655–675 pass tokio-runtime, embassy-runtime or critical-section-std-impl to connector crates.
  • Manifests: aimdb-client/Cargo.toml:44, aimdb-bench/Cargo.toml:103, aimdb-knx-connector/Cargo.toml:74, aimdb-mqtt-connector/Cargo.toml (84, 104–107, 125–133, 209), tools/embedded-check-fixture/Cargo.toml:33.
  • Examples: tokio-mqtt-connector-demo, tokio-knx-connector-demo, remote-access-demo, sync-api-demo, and the embassy demos.

(tokio-runtime on aimdb-tokio-adapter and embassy-runtime on aimdb-embassy-adapter are real features of those crates, not aliases — those uses are fine and out of scope.)

Suggested work

  1. Replace alias uses on the connector crates with the canonical features (std, connector, server) in the Makefile, crate manifests and examples.
  2. Once nothing in-tree uses them, decide on removal: delete in the next breaking release, or keep for one more cycle with a CHANGELOG note.
  3. aimdb-knx-connector's critical-section-std-impl = [] is already an empty feature and can go as soon as its callers are updated.

Notes

Found by grep over manifests, Makefile and workflows at d9c7be0. Each call site needs a check of which crate the feature is being passed to before editing, because the same names are legitimate on the adapter crates.

Lenguaje dominante
Rust
Estrellas
101
Forks
20
Merge medio
2 h 33 min
PR fusionados (30 d)
90

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de aimdb-dev/aimdb

Todos los issues de aimdb-dev/aimdb

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.