fix(telemetry): isolate unreadable sources during ingestion and reporting
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Accessibilité débutants
- 35/100
- Type d'issue
- Bug
- Clarté
- Plutôt claire
- Activité
- Active
- Stack technique
- node.js, typescript
- Domaine
- backend, testing-qa
Piste de recherche
Start with cli/src/contexts/telemetry/application/ingest-usage-use-case.ts and trace how reader failures stop storage; then read the read, transcript, report, and catch-up files named in the issue. Use cli/tests/helpers/ports/in-memory-telemetry.ts to understand the reproduction and regression tests. Done means healthy consented records survive a source failure, the stored ledger remains reportable with a clear partial-error indication, and failed positions can be retried without losing or duplicating calls.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Objective / Problem
A reader error aborts ingestion for every tool. A valid, consenting call from the healthy reader is not stored, and report cannot read the existing ledger because it first awaits ingestion.
Reproduction and observed behavior
Reproduced on next commit da3a99c5903f911df5e4e6201d946a28c7937efd, using the real normalizer/read/resolve/ingest use cases and the existing in-memory telemetry test ports. No provider or personal transcript is needed.
- Seed one valid Claude usage line and its consenting clone, using
InMemoryTranscripts,FakeLocator,FakeConsentsandInMemoryConsentHistoryfromcli/tests/helpers/ports/in-memory-telemetry.ts. - Register that reader alongside a second reader whose
execute()throwsEACCESafter the healthy read completes. - Execute
IngestUsageUseCase; compare with the same setup using an empty but healthy second reader.
| Case | Healthy records | Result | Ledger writes | Stored calls |
|---|---|---|---|---|
| Second reader fails | 1 | EACCES |
0 | 0 |
| Healthy control | 1 | success | 1 | 1 |
The synthetic assertions passed. Actual source opening/traversal also propagates EACCES; the Codex source integration suite explicitly tests that rejection.
Expected behavior / Proposed solution
Isolate source failures so valid, consented records from healthy sources can still be stored and the existing ledger remains reportable. Identify the failed source explicitly, preserve its retry position and never represent failure as zero usage. Do not weaken global consent validation.
Keep hook catch-up non-blocking, while making the failure diagnosable through the CLI. Choose and document whether containment is per tool, transcript or unreadable subtree.
Technical context
cli/src/contexts/telemetry/application/ingest-usage-use-case.ts: the readerPromise.allrejects before storage.cli/src/contexts/telemetry/application/read-usage-use-case.tsandinfrastructure/transcripts/transcript-files.ts: unreadable files/subtrees propagate errors.cli/src/contexts/telemetry/application/report/report-usage-use-case.ts: ingestion precedes reading the stored ledger.plugins/aidd-telemetry/hooks/catch-up.cjs: catch-up output/status is suppressed.
Related: #689 established reader failure isolation in the previous architecture; this is a reproducible defect in the replacement pipeline. #297 and #707 cover the broader source investigation and runtime evidence. No native OTel integration is required to fix this defect.
Acceptance / QA
- Readable Claude + failing Codex, and the reverse, preserve healthy consented records.
- An unreadable file/subtree has an explicit diagnostic and a documented containment boundary.
- Failed-source positions remain retryable; a later successful read neither loses nor duplicates calls.
- The existing ledger remains reportable with an explicit partial/source-error indication.
- Unknown counters, failed sources and genuine zero consumption remain distinct; consent still fails closed.
- Regression tests prove the failing cases and healthy controls without personal data or a provider call.
- Langage dominant
- TypeScript
- Étoiles
- 481
- Forks
- 45
- Merge moyen
- 1 j 9 h
- PR mergées (30 j)
- 86
Préparer son environnement
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de ai-driven-dev/framework
-
Difficulté 2/5 1-3 heures Accessibilité débutants 83/100
ai-driven-dev/framework#1035 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 88/100
ai-driven-dev/framework#1002 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
ai-driven-dev/framework#952 ·
Les mainteneurs répondent en général sous 1 jour
-
refactor(aidd-orchestrator): the check zone says when to stop, and reviews its axes in one roundOuverte
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
ai-driven-dev/framework#887 · 2 commentaires ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 35/100
ai-driven-dev/framework#1052 ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de ai-driven-dev/framework
Issues similaires
-
Difficulté 2/5 1-3 heures Accessibilité débutants 83/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 1/5 1-3 heures Accessibilité débutants 72/100
zts212653/clowder-ai#1678 ·
Les mainteneurs répondent en général sous 1 jour
-
good first issue
Difficulté 2/5 1-3 heures Accessibilité débutants 64/100
Progressive-Victory/the-website#680 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
Les mainteneurs répondent en général sous 1 jour
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100