Pin workflow actions to commit SHAs and npm exactly in publish

Ouverte
#117 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
72/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
github-actions, typescript
Domaine
ci-cd, security

Piste de recherche

Start with .github/workflows/publish.yml and compare its uses: references and npm install command with the suggested changes; then inspect release.yml, drift-check.yml, ci.yml, pages.yml, stale.yml, and label-sync.yml for the remaining action references. Pin actions to full commit SHAs, select an exact npm version, and apply the listed publish workflow changes. Done when the requested workflow hardening is reflected in those files.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

dependencies severity: low

Summary

Every workflow uses: points at a mutable tag, including in the publish job that holds id-token: write for npm trusted publishing. publish.yml also installs a floating npm version. This is hardening; there is no known exploit.

Where

  • .github/workflows/publish.yml:8-10, .github/workflows/publish.yml:19-27 (actions/checkout@v7 and actions/setup-node@v7 under id-token: write; npm install -g npm@^11.5.1; cache: npm)
  • .github/workflows/release.yml (contents: write, actions: write)
  • .github/workflows/drift-check.yml:18 (a third-party org action @v1.20)
  • every other uses: in ci.yml, pages.yml, stale.yml and label-sync.yml

Suggested fix

  • Pin actions to full commit SHAs with a # vX.Y comment, at least in publish.yml and release.yml. Dependabot already watches github-actions and will bump the SHAs.
  • Pin npm to an exact version in publish.yml.
  • Drop cache: npm from the publish job, so a poisoned cache cannot reach the token-minting job.
  • Consider npm ci --ignore-scripts before the build in publish.

Getting started

  • Relevant files: .github/workflows/*.yml

Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: dependencies|.github/workflows/publish.yml|uses

Langage dominant
TypeScript
Étoiles
0
Forks
6
Merge moyen
1 j 21 h
PR mergées (30 j)
8

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/godot-correctness-mcp

Toutes les issues de TMHSDigital/godot-correctness-mcp

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.