Pin workflow actions to commit SHAs and npm exactly in publish

Abierto
#117 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github-actions, typescript
Área
ci-cd, security

Línea de trabajo

Start with .github/workflows/publish.yml and compare its uses: references and npm install command with the suggested changes; then inspect release.yml, drift-check.yml, ci.yml, pages.yml, stale.yml, and label-sync.yml for the remaining action references. Pin actions to full commit SHAs, select an exact npm version, and apply the listed publish workflow changes. Done when the requested workflow hardening is reflected in those files.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

dependencies severity: low

Summary

Every workflow uses: points at a mutable tag, including in the publish job that holds id-token: write for npm trusted publishing. publish.yml also installs a floating npm version. This is hardening; there is no known exploit.

Where

  • .github/workflows/publish.yml:8-10, .github/workflows/publish.yml:19-27 (actions/checkout@v7 and actions/setup-node@v7 under id-token: write; npm install -g npm@^11.5.1; cache: npm)
  • .github/workflows/release.yml (contents: write, actions: write)
  • .github/workflows/drift-check.yml:18 (a third-party org action @v1.20)
  • every other uses: in ci.yml, pages.yml, stale.yml and label-sync.yml

Suggested fix

  • Pin actions to full commit SHAs with a # vX.Y comment, at least in publish.yml and release.yml. Dependabot already watches github-actions and will bump the SHAs.
  • Pin npm to an exact version in publish.yml.
  • Drop cache: npm from the publish job, so a poisoned cache cannot reach the token-minting job.
  • Consider npm ci --ignore-scripts before the build in publish.

Getting started

  • Relevant files: .github/workflows/*.yml

Filed by repo-audit/full-audit at e836036. Severity: low. Effort: S. audit-key: dependencies|.github/workflows/publish.yml|uses

Lenguaje dominante
TypeScript
Estrellas
0
Forks
6
Merge medio
1 d 21 h
PR fusionados (30 d)
8

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/godot-correctness-mcp

Todos los issues de TMHSDigital/godot-correctness-mcp

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.