Wait step that clicks an image can pause a run with Pause when unfocused

Abierto
#201 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 3 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
52/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
desktop

Línea de trabajo

Start in autoclicker/core/click_engine.py, reading _windows_under_steps to see how the allowed windows are built from click and hold points, then _perform_sequence to find where a wait-image step clicks its match. The issue suggests adding the root window under the clicked point to _step_hwnds for the rest of the run. Done means a test like TestSequenceFocus.test_any_step_window_counts_as_in_front passes, where the clicked image sits in a window no step point covers and the run keeps going.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug priority: low

Summary

With Pause when unfocused on, a sequence's allowed windows are the ones under its click and hold points. A wait_image step with "click the image" set clicks wherever the image is found, so a window that appears only there is not in that set. If that click brings it to the front, the run pauses at the next step.

Where

  • autoclicker/core/click_engine.py (_windows_under_steps, _perform_sequence)

Steps to reproduce

  1. Sequence: click a button in window A that opens window B, then a wait-for-image step on a button in B with click on, then another step.
  2. Turn on Pause when unfocused and start.
  3. After the image click, B is in front and the run pauses ("waiting for the target window to be in front").

Suggested fix

After a wait step clicks its match, add the root window under that point (if it isn't ours) to _step_hwnds for the rest of the run, the same way windows under step points are added at Start.

Acceptance criteria

  • A test like TestSequenceFocus.test_any_step_window_counts_as_in_front where the clicked image is in a window no step point covers, and the run keeps going

Related: #119

Lenguaje dominante
Python
Estrellas
0
Forks
2
Merge medio
2 d 13 h
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TMHSDigital/autoclicker

Todos los issues de TMHSDigital/autoclicker

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.