Rename the ten phase/faz-named test modules to feature names and add a guard against `test_(phase|faz)N` file names

Ouverte
  • Quelque chose ne va pas ?
#911 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
55/100
Type d'issue
Refactorisation
Clarté
Plutôt claire
Activité
Active
Stack technique
github-actions, python
Domaine
testing, tooling

Piste de recherche

The ten phase-named modules are under tests/ (for example tests/test_phase7.py and tests/test_faz27_narrow_exceptions.py); grep for each name to find its code comments, standards, review-pr skill mirrors and ci.yml references. tools/check_test_naming.py is new and must reject names matching test_(phase|faz)\d+, then be wired into CI and the gauntlet. Done when the renames use git mv, no live reference uses the old names, the guard passes in CI, and the row is removed from docs/roadmap/risks-and-decisions.md with the ID named in the CHANGELOG.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area: dev-tooling severity: low source: roadmap wave: 4

Deferred work · F-PR29-A4-04 · severity Low · cost ~2 h · recorded in docs/roadmap/risks-and-decisions.md:82

Summary

testing.md asks for one test_<module>.py per forgelm/<module>.py where practical, but ten test modules are named after review phases — test_phase7.py, test_phase12_5.py, test_phase12_review_fixes.py, test_data_audit_phase12.py, test_ingestion_phase12.py, test_cli_phase10.py, test_wizard_phase11.py, test_wizard_phase11_5.py, test_faz27_narrow_exceptions.py and, added after the deferral, test_wizard_phase22.py. With no guard the pattern keeps spreading.

Condition or budget

None recorded (the row still names v0.6.x).

State today (re-checked 2026-10-09)

All ten files are under tests/; tools/check_test_naming.py does not exist.

Acceptance criteria

  • Each module is renamed with git mv (history preserved) or folded into the matching test_<module>.py, and every live reference (code comments, standards, both review-pr skill mirrors, ci.yml) moves with it.
  • tools/check_test_naming.py rejects test_(phase|faz)\d+ names and is wired into CI and the gauntlet.
  • The row is removed from the deferral table and the CHANGELOG names its ID (the table's removal contract).

Recorded in docs/roadmap/risks-and-decisions.md (read at f94595f) and re-checked against the code on 2026-10-09. The row leaves that table only when the fix is on main, the CHANGELOG names its ID and any promised guard exists.

Langage dominant
Python
Étoiles
9
Forks
1
Merge moyen
9 h 17 min
PR mergées (30 j)
60

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de HodeTech/ForgeLM

Toutes les issues de HodeTech/ForgeLM

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.