deploy.sh sends replicated: true to every target: confirm behavior on a standalone node and with a peer down

Ouverte
#43 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
javascript
Domaine
devops

Piste de recherche

Start with deploy/deploy.sh and inspect how it passes replicated: true to deploy_component and checks replicated[]. Run the two deployment scenarios named in the issue: a standalone container and a cluster with one peer stopped. Record the observed behavior, then document it in the env READMEs or gate replication per env dir; done means the chosen behavior is clear for both topologies.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

deploy/deploy.sh always sends replicated: true to deploy_component, and exits 1 when replicated[] reports a failed or errored peer. It inherited this from the engineering script; the shared script now serves any env dir, so the assumption reaches targets with other topologies.

Open questions

  • On a standalone (unclustered) node, does deploy_component accept replicated: true, and does replicated[] come back empty so the exit check passes? A review noted this is untested; another reasoned it passes.
  • When one peer is down, the contacted node has already applied the deploy and the script exits 1. That reads as the right signal (a peer missed it), but the script does not say which state each node is in.

Resolution

Run one deploy against a standalone container and one with a peer stopped, then either document the behavior in the env READMEs or gate replicated per env dir.

Review-Deferral: aab09f59d96a02fc severity=nit category=reliability

🤖 Generated by Claude Sonnet 5.5 via Claude Code; posted via @kriszyp; requested by @kriszyp.

Langage dominant
JavaScript
Étoiles
0
Forks
0
Merge moyen
20 h 29 min
PR mergées (30 j)
28

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de HarperFast/agent-memory

Toutes les issues de HarperFast/agent-memory

Issues similaires

Plus d'issues JavaScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.