deploy.sh sends replicated: true to every target: confirm behavior on a standalone node and with a peer down

Abierto
#43 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
javascript
Área
devops

Línea de trabajo

Start with deploy/deploy.sh and inspect how it passes replicated: true to deploy_component and checks replicated[]. Run the two deployment scenarios named in the issue: a standalone container and a cluster with one peer stopped. Record the observed behavior, then document it in the env READMEs or gate replication per env dir; done means the chosen behavior is clear for both topologies.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

deploy/deploy.sh always sends replicated: true to deploy_component, and exits 1 when replicated[] reports a failed or errored peer. It inherited this from the engineering script; the shared script now serves any env dir, so the assumption reaches targets with other topologies.

Open questions

  • On a standalone (unclustered) node, does deploy_component accept replicated: true, and does replicated[] come back empty so the exit check passes? A review noted this is untested; another reasoned it passes.
  • When one peer is down, the contacted node has already applied the deploy and the script exits 1. That reads as the right signal (a peer missed it), but the script does not say which state each node is in.

Resolution

Run one deploy against a standalone container and one with a peer stopped, then either document the behavior in the env READMEs or gate replicated per env dir.

Review-Deferral: aab09f59d96a02fc severity=nit category=reliability

🤖 Generated by Claude Sonnet 5.5 via Claude Code; posted via @kriszyp; requested by @kriszyp.

Lenguaje dominante
JavaScript
Estrellas
0
Forks
0
Merge medio
20 h 29 min
PR fusionados (30 d)
28

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de HarperFast/agent-memory

Todos los issues de HarperFast/agent-memory

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.