envsubst: unexpected behaviour for +, = and ?
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start with the envsubst implementation and the supported syntax described in README. Trace parsing for ${parameter:+word}, ${parameter:=word}, and ${parameter:?word}, then compare the behavior with the linked Bash reference. Done means unsupported operators no longer silently behave like :-, with coverage demonstrating the expected results.
Written by the indexing model from the issue text.
Description
In envsubst, it appears like ${parameter:+word}, ${parameter:=word} and ${parameter:?word} are all treated as if they were${parameter:-word}. According to the README, + and ? are unsupported, but I would expect an error instead of this behaviour.
From the bash reference manual:
${parameter:-word}: If parameter is unset or null, the expansion of word is substituted. Otherwise, the value of parameter is substituted.${parameter:=word}: If parameter is unset or null, the expansion of word is assigned to parameter. The value of parameter is then substituted. Positional parameters and special parameters may not be assigned to in this way.${parameter:?word}: If parameter is null or unset, the expansion of word (or a message to that effect if word is not present) is written to the standard error and the shell, if it is not interactive, exits. Otherwise, the value of parameter is substituted.${parameter:+word}: If parameter is null or unset, nothing is substituted, otherwise the expansion of word is substituted.
= and - are quite similar, and will function as expected in most use cases.
? should not substitute anything, but error if unset.
+ currently does the exact opposite of what it's supposed to do.
- Dominant language
- Go
- Stars
- 63
- Forks
- 162
- Avg merge
- 9h 54m
- Merged PRs (30d)
- 29
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluxcd/pkg
-
ssa: wait errors drop the kstatus message, so health check failures don't say whyPossibly taken @schdief claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
ssa/jsondiff: honor ignored fields before dry-run validationPossibly taken @lubronzhan claimed this 31 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 30/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
Improve `make release` to support major version bumpsPossibly taken @Iam-Karan-Suresh claimed this 175 days ago. Openarea/ci
fluxcd/pkg#1172 · 3 comments · 1 reaction · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Pin and verify Security Insights schema in lintinsights targetPossibly taken @imshubham22apr-gif claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
gemaraproj/gemara#618 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
a2aproject/a2a-go#597 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 4 days
-
scopes: GetAllowedTopics, GetProtectedTopics, and GetScopedTopics include empty topic names and do not trim whitespace charactersPossibly taken @patelshivani2283-lab claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area/networking kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
siderolabs/talos#14972 ·
Maintainers usually reply within 1 day