ssa: wait errors drop the kstatus message, so health check failures don't say why
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- go
- Domain
- backend, observability-sre
Research direction
Start with ssa/manager_wait.go#L174-LL186, where ResourceManager.WaitForSetWithContext formats errors for objects that are not ready, and trace how it receives each object's kstatus message. Append that message when there is no poller error, as proposed in the issue. Add or update coverage for both cases and confirm the existing error format remains intact when a poller error is present.
Written by the indexing model from the issue text.
Description
ResourceManager.WaitForSetWithContext reports each object that didn't become ready as
<Kind>/<ns>/<name> status: '<Status>', plus the poller error, if any
(manager_wait.go#L174-L186).
kstatus already computes a human-readable Message for every object
(event.ResourceStatus.Message in fluxcd/cli-utils), but it is dropped.
kustomize-controller copies this error into the Ready/Healthy conditions and the
HealthCheckFailed event, so users see for example:
health check failed after 5m0s: timeout waiting for: [HelmRelease/apps/podinfo status: 'InProgress']
This says which object is not ready, but not why. The information is one field away:
| Object | kstatus Message (examples) |
|---|---|
| HelmRelease, upgrade failed, retries left | the Ready message, e.g. Helm upgrade failed for release apps/podinfo with chart [email protected]: context deadline exceeded (helm-controller copies it into Reconciling, atomic_release.go#L315) |
| HelmRelease, retries exhausted | Failed to upgrade after 1 attempt(s) (Stalled, atomic_release.go#L206) |
| Deployment | e.g. Available: 0/1, Deployment generation is 2, but latest observed generation is 1, Progress deadline exceeded |
| PersistentVolumeClaim | PVC is not Bound. phase: Pending |
| missing object | Resource not found |
Proposal: append the message when there's no poller error. The format stays the same; the
message is only added at the end. I'll open a PR for this.
Related: fluxcd/kustomize-controller#1431 (unhelpful health check notifications), #722
(wait error reporting).
- Dominant language
- Go
- Stars
- 63
- Forks
- 162
- Avg merge
- 9h 54m
- Merged PRs (30d)
- 29
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluxcd/pkg
-
ssa/jsondiff: honor ignored fields before dry-run validationPossibly taken @lubronzhan claimed this 31 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 30/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
Improve `make release` to support major version bumpsPossibly taken @Iam-Karan-Suresh claimed this 175 days ago. Openarea/ci
fluxcd/pkg#1172 · 3 comments · 1 reaction · 1 assignee ·
Maintainers usually reply within 1 day
-
Bug: `runtime/client.(*Impersonator).CanImpersonate` does not take kubeconfig into accountMay be free again @yuminn-k claimed this 16 days ago, and no pull request is open. Open
Difficulty 3/5 1-2 days Newbie friendliness 49/100
Maintainers usually reply within 1 day
Similar issues
-
Pin and verify Security Insights schema in lintinsights targetPossibly taken @imshubham22apr-gif claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
gemaraproj/gemara#618 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
a2aproject/a2a-go#597 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 4 days
-
scopes: GetAllowedTopics, GetProtectedTopics, and GetScopedTopics include empty topic names and do not trim whitespace charactersPossibly taken @patelshivani2283-lab claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area/networking kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
siderolabs/talos#14972 ·
Maintainers usually reply within 1 day