ssa: wait errors drop the kstatus message, so health check failures don't say why

Open Beginner friendly
#1,379 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@schdief is already working on this.

Since Nov 16, 2026.

  • #1380 by @schdief — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
go

Research direction

Start with ssa/manager_wait.go#L174-LL186, where ResourceManager.WaitForSetWithContext formats errors for objects that are not ready, and trace how it receives each object's kstatus message. Append that message when there is no poller error, as proposed in the issue. Add or update coverage for both cases and confirm the existing error format remains intact when a poller error is present.

Written by the indexing model from the issue text.

Description

ResourceManager.WaitForSetWithContext reports each object that didn't become ready as
<Kind>/<ns>/<name> status: '<Status>', plus the poller error, if any
(manager_wait.go#L174-L186).
kstatus already computes a human-readable Message for every object
(event.ResourceStatus.Message in fluxcd/cli-utils), but it is dropped.

kustomize-controller copies this error into the Ready/Healthy conditions and the
HealthCheckFailed event, so users see for example:

health check failed after 5m0s: timeout waiting for: [HelmRelease/apps/podinfo status: 'InProgress']

This says which object is not ready, but not why. The information is one field away:

Object kstatus Message (examples)
HelmRelease, upgrade failed, retries left the Ready message, e.g. Helm upgrade failed for release apps/podinfo with chart [email protected]: context deadline exceeded (helm-controller copies it into Reconciling, atomic_release.go#L315)
HelmRelease, retries exhausted Failed to upgrade after 1 attempt(s) (Stalled, atomic_release.go#L206)
Deployment e.g. Available: 0/1, Deployment generation is 2, but latest observed generation is 1, Progress deadline exceeded
PersistentVolumeClaim PVC is not Bound. phase: Pending
missing object Resource not found

Proposal: append the message when there's no poller error. The format stays the same; the
message is only added at the end. I'll open a PR for this.

Related: fluxcd/kustomize-controller#1431 (unhelpful health check notifications), #722
(wait error reporting).

Dominant language
Go
Stars
63
Forks
162
Avg merge
9h 54m
Merged PRs (30d)
29

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fluxcd/pkg

All issues in fluxcd/pkg

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.