A test project passes with zero tests, and the CI shards are listed by hand

Open
#3,311 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, github-actions, postgresql

Research direction

Start with Directory.Build.props:73-76, .github/workflows/ci.yml:90-106, DatabaseServer.cs:90, and SqlServerPool.cs:32-45 to trace the test settings, shard coverage, and existing database template approach. Check how the solution discovers test projects and how PostgreSQL tests create and migrate databases. Done means empty test projects fail, every test project is covered by a shard, and PostgreSQL tests migrate once per run; record the time saved in the pull request. Coordinate with #3267, which changes the same workflow.

Written by the indexing model from the issue text.

Description

area:build area:testing type:bug

Problem

  1. A test project passes when it runs no tests. Directory.Build.props:73-76 sets --ignore-exit-code 8 for every project under tests/, with a comment about stubs that no longer applies. Filtered runs are guarded by --minimum-expected-tests; the unfiltered shards (.github/workflows/ci.yml:90,101-106) are not.
  2. The shard lists are maintained by hand. ci.yml:90-106 names each test project. A new one runs on no pull request and no push to main; only the nightly Windows run picks it up.
  3. PostgreSQL tests create and migrate a database per test. DatabaseServer.cs:90 runs CREATE DATABASE for each test, and each test migrates it. SQL Server already clones a migrated template (SqlServerPool.cs:32-45).

Proposal

  • Remove the ignored exit code.
  • A check that every test project of the solution is in a shard.
  • Migrate one template database per run and create test databases from it.

Done together with #3267, which changes the same workflow.

Acceptance

  • A test project that discovers no tests fails the run
  • A test project missing from the shards fails CI
  • PostgreSQL tests no longer migrate per test; the time saved is noted in the pull request

Found in the code review of 17 Nov 2026.

Dominant language
C#
Stars
569
Forks
107
Avg merge
2h 49m
Merged PRs (30d)
397

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fluentcms/FluentCMS

All issues in fluentcms/FluentCMS

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.