A test project passes with zero tests, and the CI shards are listed by hand

Abierto
#3,311 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp, github-actions, postgresql

Línea de trabajo

Start with Directory.Build.props:73-76, .github/workflows/ci.yml:90-106, DatabaseServer.cs:90, and SqlServerPool.cs:32-45 to trace the test settings, shard coverage, and existing database template approach. Check how the solution discovers test projects and how PostgreSQL tests create and migrate databases. Done means empty test projects fail, every test project is covered by a shard, and PostgreSQL tests migrate once per run; record the time saved in the pull request. Coordinate with #3267, which changes the same workflow.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:build area:testing type:bug

Problem

  1. A test project passes when it runs no tests. Directory.Build.props:73-76 sets --ignore-exit-code 8 for every project under tests/, with a comment about stubs that no longer applies. Filtered runs are guarded by --minimum-expected-tests; the unfiltered shards (.github/workflows/ci.yml:90,101-106) are not.
  2. The shard lists are maintained by hand. ci.yml:90-106 names each test project. A new one runs on no pull request and no push to main; only the nightly Windows run picks it up.
  3. PostgreSQL tests create and migrate a database per test. DatabaseServer.cs:90 runs CREATE DATABASE for each test, and each test migrates it. SQL Server already clones a migrated template (SqlServerPool.cs:32-45).

Proposal

  • Remove the ignored exit code.
  • A check that every test project of the solution is in a shard.
  • Migrate one template database per run and create test databases from it.

Done together with #3267, which changes the same workflow.

Acceptance

  • A test project that discovers no tests fails the run
  • A test project missing from the shards fails CI
  • PostgreSQL tests no longer migrate per test; the time saved is noted in the pull request

Found in the code review of 17 Nov 2026.

Lenguaje dominante
C#
Estrellas
569
Forks
107
Merge medio
2 h 49 min
PR fusionados (30 d)
397

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.