Clients return null, cannot be cancelled and drop Retry-After; the SDK reads the system clock
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- csharp, typescript
- Domain
- backend-api-design, testing
Research direction
Start with the listed locations: FluentCmsClient.cs, clients/typescript/src/client.ts, SystemOperation.cs, CmsEvent.cs, docs/analyzers.md, and Descriptors.cs; inspect the related client, SDK, and analyzer tests and the changes in #3273. The acceptance checklist defines done across six areas, from cancellation and Retry-After handling to API baselines and diagnostic documentation. This spans multiple packages and client implementations, so it requires substantial project context.
Written by the indexing model from the issue text.
Description
Problem
- The .NET client can return null for a non-nullable result.
FluentCmsClient.cs:120-123returnsdefaultfor an empty body or a 204, and:127returns null for a literalnullbody; callers suppress it with!(:32,39,47,55,62,71,85,92). A proxy answering 200 with an empty body gives aNullReferenceExceptionlater. - The TypeScript client has no cancellation or timeout.
clients/typescript/src/client.ts:100-105buildsRequestInitwithout asignal, and no method takes one. - Both clients discard
Retry-Afteron a 429.FluentCmsClient.cs:114andclient.ts:107-108pass only the status and body to the error. - The SDK reads the system clock directly.
src/FluentCMS.Sdk/Content/SystemOperation.cs:42andsrc/FluentCMS.Sdk/Events/CmsEvent.cs:9useDateTimeOffset.UtcNowinstead of the injectedTimeProvider. FluentCMS.Clienthas no tracked public API, unlike Sdk, Plugins.Abstractions and the two admin packages.- FCMS0100–FCMS0104 are undocumented.
docs/analyzers.md:5only reserves the range, andsrc/FluentCMS.Generators/Descriptors.cssets nohelpLinkUri, unlikesrc/FluentCMS.Analyzers/Rules.cs:22.
Proposal
- Throw
FluentCmsProblemExceptionwhen a result is expected and the body is empty ornull. - Accept a
signalper call and atimeoutMsoption in the TypeScript client. - Expose
RetryAfteron the problem type of both clients. - Take a
TimeProviderinSystemOperation; let the bus stamp events. - Add the public API analyzer and baseline to
FluentCMS.Client. - Document the five diagnostics and link them.
Done together with #3273, which changes the same two clients.
Acceptance
- An empty or
nullbody where a result is expected throws a problem exception - A TypeScript call can be aborted, and times out at
timeoutMs - A 429 exposes the
Retry-Afterof the server in both clients - No
DateTimeOffset.UtcNowremains inFluentCMS.Sdk - A change to the public API of
FluentCMS.Clientfails the build until the baseline is updated - Each of FCMS0100–FCMS0104 has a section in
docs/analyzers.mdand a help link
Found in the code review of 17 Nov 2026.
- Dominant language
- C#
- Stars
- 569
- Forks
- 107
- Avg merge
- 2h 49m
- Merged PRs (30d)
- 397
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluentcms/FluentCMS
-
area:host area:operations type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:build security type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:sdk security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:content security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area:build type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in fluentcms/FluentCMS
Similar issues
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
microsoft/microsoft-ui-reactor#1567 ·
Maintainers usually reply within 1 day
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
openclaw/openclaw-windows-node#2287 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
kind:ux needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
elsa-workflows/elsa-foundation#4742 ·
Maintainers usually reply within 1 day
-
priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
enhancement good first issue help wanted new-language
Difficulty 2/5 1-3 hours Newbie friendliness 82/100