Clients return null, cannot be cancelled and drop Retry-After; the SDK reads the system clock

Open
#3,310 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp, typescript

Research direction

Start with the listed locations: FluentCmsClient.cs, clients/typescript/src/client.ts, SystemOperation.cs, CmsEvent.cs, docs/analyzers.md, and Descriptors.cs; inspect the related client, SDK, and analyzer tests and the changes in #3273. The acceptance checklist defines done across six areas, from cancellation and Retry-After handling to API baselines and diagnostic documentation. This spans multiple packages and client implementations, so it requires substantial project context.

Written by the indexing model from the issue text.

Description

area:sdk type:bug

Problem

  1. The .NET client can return null for a non-nullable result. FluentCmsClient.cs:120-123 returns default for an empty body or a 204, and :127 returns null for a literal null body; callers suppress it with ! (:32,39,47,55,62,71,85,92). A proxy answering 200 with an empty body gives a NullReferenceException later.
  2. The TypeScript client has no cancellation or timeout. clients/typescript/src/client.ts:100-105 builds RequestInit without a signal, and no method takes one.
  3. Both clients discard Retry-After on a 429. FluentCmsClient.cs:114 and client.ts:107-108 pass only the status and body to the error.
  4. The SDK reads the system clock directly. src/FluentCMS.Sdk/Content/SystemOperation.cs:42 and src/FluentCMS.Sdk/Events/CmsEvent.cs:9 use DateTimeOffset.UtcNow instead of the injected TimeProvider.
  5. FluentCMS.Client has no tracked public API, unlike Sdk, Plugins.Abstractions and the two admin packages.
  6. FCMS0100–FCMS0104 are undocumented. docs/analyzers.md:5 only reserves the range, and src/FluentCMS.Generators/Descriptors.cs sets no helpLinkUri, unlike src/FluentCMS.Analyzers/Rules.cs:22.

Proposal

  • Throw FluentCmsProblemException when a result is expected and the body is empty or null.
  • Accept a signal per call and a timeoutMs option in the TypeScript client.
  • Expose RetryAfter on the problem type of both clients.
  • Take a TimeProvider in SystemOperation; let the bus stamp events.
  • Add the public API analyzer and baseline to FluentCMS.Client.
  • Document the five diagnostics and link them.

Done together with #3273, which changes the same two clients.

Acceptance

  • An empty or null body where a result is expected throws a problem exception
  • A TypeScript call can be aborted, and times out at timeoutMs
  • A 429 exposes the Retry-After of the server in both clients
  • No DateTimeOffset.UtcNow remains in FluentCMS.Sdk
  • A change to the public API of FluentCMS.Client fails the build until the baseline is updated
  • Each of FCMS0100–FCMS0104 has a section in docs/analyzers.md and a help link

Found in the code review of 17 Nov 2026.

Dominant language
C#
Stars
569
Forks
107
Avg merge
2h 49m
Merged PRs (30d)
397

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fluentcms/FluentCMS

All issues in fluentcms/FluentCMS

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.