Clients return null, cannot be cancelled and drop Retry-After; the SDK reads the system clock

Abierto
#3,310 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp, typescript

Línea de trabajo

Start with the listed locations: FluentCmsClient.cs, clients/typescript/src/client.ts, SystemOperation.cs, CmsEvent.cs, docs/analyzers.md, and Descriptors.cs; inspect the related client, SDK, and analyzer tests and the changes in #3273. The acceptance checklist defines done across six areas, from cancellation and Retry-After handling to API baselines and diagnostic documentation. This spans multiple packages and client implementations, so it requires substantial project context.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:sdk type:bug

Problem

  1. The .NET client can return null for a non-nullable result. FluentCmsClient.cs:120-123 returns default for an empty body or a 204, and :127 returns null for a literal null body; callers suppress it with ! (:32,39,47,55,62,71,85,92). A proxy answering 200 with an empty body gives a NullReferenceException later.
  2. The TypeScript client has no cancellation or timeout. clients/typescript/src/client.ts:100-105 builds RequestInit without a signal, and no method takes one.
  3. Both clients discard Retry-After on a 429. FluentCmsClient.cs:114 and client.ts:107-108 pass only the status and body to the error.
  4. The SDK reads the system clock directly. src/FluentCMS.Sdk/Content/SystemOperation.cs:42 and src/FluentCMS.Sdk/Events/CmsEvent.cs:9 use DateTimeOffset.UtcNow instead of the injected TimeProvider.
  5. FluentCMS.Client has no tracked public API, unlike Sdk, Plugins.Abstractions and the two admin packages.
  6. FCMS0100–FCMS0104 are undocumented. docs/analyzers.md:5 only reserves the range, and src/FluentCMS.Generators/Descriptors.cs sets no helpLinkUri, unlike src/FluentCMS.Analyzers/Rules.cs:22.

Proposal

  • Throw FluentCmsProblemException when a result is expected and the body is empty or null.
  • Accept a signal per call and a timeoutMs option in the TypeScript client.
  • Expose RetryAfter on the problem type of both clients.
  • Take a TimeProvider in SystemOperation; let the bus stamp events.
  • Add the public API analyzer and baseline to FluentCMS.Client.
  • Document the five diagnostics and link them.

Done together with #3273, which changes the same two clients.

Acceptance

  • An empty or null body where a result is expected throws a problem exception
  • A TypeScript call can be aborted, and times out at timeoutMs
  • A 429 exposes the Retry-After of the server in both clients
  • No DateTimeOffset.UtcNow remains in FluentCMS.Sdk
  • A change to the public API of FluentCMS.Client fails the build until the baseline is updated
  • Each of FCMS0100–FCMS0104 has a section in docs/analyzers.md and a help link

Found in the code review of 17 Nov 2026.

Lenguaje dominante
C#
Estrellas
569
Forks
107
Merge medio
2 h 49 min
PR fusionados (30 d)
397

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.