Failed passwords lock an admin out of sessions they already have

Open
#3,271 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp

Research direction

Start with MaySignInAsync and the authorize, refresh redemption, and member sign-in paths named in ConnectEndpoints.cs and MemberConnect.cs. Trace how lockout, deactivation, and security stamp checks affect existing cookie sessions and refresh tokens. Add coverage for the two acceptance conditions, then verify that lockout blocks password sign-in while existing sessions survive until deactivation or a new stamp.

Written by the indexing model from the issue text.

Description

area:identity security type:bug

Problem

MaySignInAsync includes lockout and gates the authorize endpoint with a valid cookie and code and refresh redemption (ConnectEndpoints.cs:97,197,501-502; members: MemberConnect.cs:80). Lockout is raised by unauthenticated failed passwords (5 attempts, 5 minutes). An attacker who knows an admin's user name sends 5 wrong passwords every 5 minutes from one address, and the admin's admin and MCP sessions all fail; repeated for every Super Admin it keeps every administrator out.

Proposal

Let only deactivation and a new security stamp end existing sessions; keep lockout for password sign-in. Consider a per-account plus per-address throttle so a lockout is not global.

Acceptance

  • A locked-out user's existing refresh tokens and cookie sessions keep working
  • Deactivation and a new stamp still end them

Found in the code review of 17 Nov 2026 (S5).

Dominant language
C#
Stars
569
Forks
107
Avg merge
2h 49m
Merged PRs (30d)
397

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fluentcms/FluentCMS

All issues in fluentcms/FluentCMS

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.