Failed passwords lock an admin out of sessions they already have

Abierto
#3,271 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp

Línea de trabajo

Start with MaySignInAsync and the authorize, refresh redemption, and member sign-in paths named in ConnectEndpoints.cs and MemberConnect.cs. Trace how lockout, deactivation, and security stamp checks affect existing cookie sessions and refresh tokens. Add coverage for the two acceptance conditions, then verify that lockout blocks password sign-in while existing sessions survive until deactivation or a new stamp.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:identity security type:bug

Problem

MaySignInAsync includes lockout and gates the authorize endpoint with a valid cookie and code and refresh redemption (ConnectEndpoints.cs:97,197,501-502; members: MemberConnect.cs:80). Lockout is raised by unauthenticated failed passwords (5 attempts, 5 minutes). An attacker who knows an admin's user name sends 5 wrong passwords every 5 minutes from one address, and the admin's admin and MCP sessions all fail; repeated for every Super Admin it keeps every administrator out.

Proposal

Let only deactivation and a new security stamp end existing sessions; keep lockout for password sign-in. Consider a per-account plus per-address throttle so a lockout is not global.

Acceptance

  • A locked-out user's existing refresh tokens and cookie sessions keep working
  • Deactivation and a new stamp still end them

Found in the code review of 17 Nov 2026 (S5).

Lenguaje dominante
C#
Estrellas
569
Forks
107
Merge medio
2 h 49 min
PR fusionados (30 d)
397

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fluentcms/FluentCMS

Todos los issues de fluentcms/FluentCMS

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.