Secret settings are stored in plaintext
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start with SettingsService.StoreAsync and the code that resolves settings, especially handling of [SettingsSecret] values such as AiSettings.ApiKey. Trace how the startup report is built and how settings are written to cms_setting.json; the proposal specifies the protection purpose and when existing values should be migrated. Done means stored secrets are protected, existing plaintext values still resolve and become protected on their next write, and unprotected secrets are reported at startup.
Written by the indexing model from the issue text.
Description
Problem
[SettingsSecret] values such as AiSettings.ApiKey are written as is to cms_setting.json (SettingsService.StoreAsync); only Management API reads redact them. A database reader, a backup or a replica gets third-party API keys, even on a host with a certificate-protected key ring.
Proposal
Protect secrets with IDataProtector (purpose settings:{area}:{key}) on write and unprotect on resolve; report unprotected secrets in the startup report; migrate existing values on first write.
Acceptance
- A secret setting is not readable from the database
- Existing plaintext values keep working and are protected on their next write
Found in the code review of 17 Nov 2026 (S4).
- Dominant language
- C#
- Stars
- 569
- Forks
- 107
- Avg merge
- 2h 49m
- Merged PRs (30d)
- 397
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluentcms/FluentCMS
-
area:host area:operations type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:build security type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:sdk security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:content security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area:build type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in fluentcms/FluentCMS
Similar issues
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
microsoft/microsoft-ui-reactor#1567 ·
Maintainers usually reply within 1 day
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
openclaw/openclaw-windows-node#2287 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
kind:ux needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
elsa-workflows/elsa-foundation#4742 ·
Maintainers usually reply within 1 day
-
priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
enhancement good first issue help wanted new-language
Difficulty 2/5 1-3 hours Newbie friendliness 82/100