Secret settings are stored in plaintext

未关闭
#3,270 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
csharp
领域
backend, security

调研方向

Start with SettingsService.StoreAsync and the code that resolves settings, especially handling of [SettingsSecret] values such as AiSettings.ApiKey. Trace how the startup report is built and how settings are written to cms_setting.json; the proposal specifies the protection purpose and when existing values should be migrated. Done means stored secrets are protected, existing plaintext values still resolve and become protected on their next write, and unprotected secrets are reported at startup.

由索引模型根据 Issue 内容生成。

描述

area:settings security type:bug

Problem

[SettingsSecret] values such as AiSettings.ApiKey are written as is to cms_setting.json (SettingsService.StoreAsync); only Management API reads redact them. A database reader, a backup or a replica gets third-party API keys, even on a host with a certificate-protected key ring.

Proposal

Protect secrets with IDataProtector (purpose settings:{area}:{key}) on write and unprotect on resolve; report unprotected secrets in the startup report; migrate existing values on first write.

Acceptance

  • A secret setting is not readable from the database
  • Existing plaintext values keep working and are protected on their next write

Found in the code review of 17 Nov 2026 (S4).

主要语言
C#
星标
569
派生
107
平均合并
2 小时 49 分钟
30 天内合并 PR
397

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。