Media purge and site deletion delete files the asset does not own
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 62/100
Research direction
Read MediaVariantCleanupJob.PurgeAsync in src/plugins/FluentCMS.Plugins.Media/MediaVariantCleanupJob.cs and DeletedSiteMedia.RemoveAsync in DeletedSiteMedia.cs, then compare their deletion logic with the replacement check and MediaTransferTests.AFileAnotherAssetNamesStaysWithItsVariants. Add coverage for deleting or purging either of two assets that name one key, including site deletion. Done means the remaining asset's file is preserved in each case.
Written by the indexing model from the issue text.
Description
Problem
MediaVariantCleanupJob.PurgeAsync (src/plugins/FluentCMS.Plugins.Media/MediaVariantCleanupJob.cs:100-116) and DeletedSiteMedia.RemoveAsync (DeletedSiteMedia.cs:285,295) call storage.DeleteAsync(asset.StorageKey) without checking asset.OwnsFile or the ReplacedFiles.NamedByOthers check that replace uses. An import can name an existing key (owned: false, see MediaTransferTests.AFileAnotherAssetNamesStaysWithItsVariants), so purging one asset deletes the original another live asset still serves, and with shared storage another instance's file.
Proposal
Delete the original only when the asset owns it and no other asset names it; otherwise remove only the row.
Acceptance
- Deleting and purging either of two assets on one key keeps the other's file
- The same for site deletion
Found in the code review of 17 Nov 2026 (B1).
- Dominant language
- C#
- Stars
- 569
- Forks
- 107
- Avg merge
- 2h 49m
- Merged PRs (30d)
- 397
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluentcms/FluentCMS
-
area:host area:operations type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:build security type:chore
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:sdk security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area:content security type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area:build type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in fluentcms/FluentCMS
Similar issues
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
microsoft/microsoft-ui-reactor#1567 ·
Maintainers usually reply within 1 day
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
openclaw/openclaw-windows-node#2287 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
kind:ux needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
elsa-workflows/elsa-foundation#4742 ·
Maintainers usually reply within 1 day
-
priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
enhancement good first issue help wanted new-language
Difficulty 2/5 1-3 hours Newbie friendliness 82/100