Media purge and site deletion delete files the asset does not own

未关闭
#3,264 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
62/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
csharp
领域
backend

调研方向

Read MediaVariantCleanupJob.PurgeAsync in src/plugins/FluentCMS.Plugins.Media/MediaVariantCleanupJob.cs and DeletedSiteMedia.RemoveAsync in DeletedSiteMedia.cs, then compare their deletion logic with the replacement check and MediaTransferTests.AFileAnotherAssetNamesStaysWithItsVariants. Add coverage for deleting or purging either of two assets that name one key, including site deletion. Done means the remaining asset's file is preserved in each case.

由索引模型根据 Issue 内容生成。

描述

area:storage plugin type:bug

Problem

MediaVariantCleanupJob.PurgeAsync (src/plugins/FluentCMS.Plugins.Media/MediaVariantCleanupJob.cs:100-116) and DeletedSiteMedia.RemoveAsync (DeletedSiteMedia.cs:285,295) call storage.DeleteAsync(asset.StorageKey) without checking asset.OwnsFile or the ReplacedFiles.NamedByOthers check that replace uses. An import can name an existing key (owned: false, see MediaTransferTests.AFileAnotherAssetNamesStaysWithItsVariants), so purging one asset deletes the original another live asset still serves, and with shared storage another instance's file.

Proposal

Delete the original only when the asset owns it and no other asset names it; otherwise remove only the row.

Acceptance

  • Deleting and purging either of two assets on one key keeps the other's file
  • The same for site deletion

Found in the code review of 17 Nov 2026 (B1).

主要语言
C#
星标
569
派生
107
平均合并
2 小时 49 分钟
30 天内合并 PR
397

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。