Propagating onEvent errors of EventListener not handled
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start with the Firestore Android codelab's “Display data from Firestore” step and inspect the EventListener.onEvent callback and FirestoreAdapter.onError entry point. Done means listen errors from an improper Query reach the protected onError method so subclasses can provide handling such as displaying a Snackbar.
Written by the indexing model from the issue text.
Description
In the Step - "Display data from Firestore", the provided code does not handle the case of propagating the Listen errors to the protected method onError() of FirestoreAdapter. If propagated, then only the user will be able to see a Snackbar in case of any Listen errors occurring due to improper Query, in the onEvent() callback of EventListener. This onError() method is overidden by subclasses of FirestoreAdapter to provide their own implementation for handling the FirebaseFirestoreException error passed to it.
- Dominant language
- Kotlin
- Stars
- 295
- Forks
- 168
- Avg merge
- 8d 9h
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from firebase/friendlyeats-android
-
Rewrite your codelabOpen
Difficulty 5/5 Over a week Newbie friendliness 30/100
firebase/friendlyeats-android#227 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
firebase/friendlyeats-android#220 · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
firebase/friendlyeats-android#212 ·
-
needs-info
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
firebase/friendlyeats-android#141 · 3 comments ·
-
needs-info
Difficulty 4/5 3-5 days Newbie friendliness 25/100
firebase/friendlyeats-android#129 · 3 comments · 1 reaction ·
All issues in firebase/friendlyeats-android
Similar issues
-
area/docs
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
nightscout/AndroidAPS#5199 · 2 comments ·
Maintainers usually reply within 1 day
-
edi-adapter-client enhancement helsemelding-edi-adapter
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
navikt/helsemelding-edi-adapter#102 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
navikt/esyfo-narmesteleder#615 ·
Maintainers usually reply within 1 day