[FR] Allow @google-cloud/storage v9 — v8 emits MaxListenersExceededWarning on every download (teeny-request stream path)

Open Beginner friendly
#3,319 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
google-cloud, node.js, typescript
Domain
backend, devtools

Research direction

Start by reading the package metadata that declares @google-cloud/storage as an optional dependency and check the existing dependency compatibility tests. Widen the supported range to include ^9.0.0, then run the relevant test suite and confirm Storage 9 is accepted. Done means the declared range and tests support the new major version.

Written by the indexing model from the issue text.

Description

Is your feature request related to a problem? Please describe.

[email protected] declares @google-cloud/storage as ^8.1.0 (optionalDependencies), so an Admin SDK app resolves Storage 8.4.0. On that version every File.createReadStream() / File.download() emits a MaxListenersExceededWarning:

(node:1) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [PassThrough]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
(node:1) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [PassThrough]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit

(These are copied verbatim from our production logs. The error and close warnings arrive as a pair, within a millisecond of each other.)

It is not a leak (heap stays flat over hundreds of downloads). But Node prints it to stderr, outside any structured logger, and to anyone reading the logs it looks like a leak.

The cause, as far as we traced it (Storage 8.4.0, teeny-request 11.1.1, Node 24):

  • teeny-request's stream mode pipes the response into its requestStream PassThrough (teeny-request/build/src/index.js, pipeline(responseStream, requestStream, ...));
  • Storage's createReadStream pipes that same raw response stream again, into its throughStream (@google-cloud/storage/build/cjs/src/file.js, pipeline(rawResponseStream, ...transformStreams, throughStream, onComplete));
  • together with node-fetch's own pipeline, three stream.pipeline calls attach their error and close listeners to the one PassThrough, which crosses the default limit of 10.

@google-cloud/[email protected] (released 2026-11-12) no longer depends on teeny-request (it uses gaxios 8), which removes this code path. We have not yet confirmed that the warning is gone on Storage 9; we're inferring it from the dependency change. Admin SDK users can't take Storage 9 without an overrides entry outside the SDK's declared range.

Describe the solution you'd like

Widen the @google-cloud/storage range to allow ^9.0.0 (its engines is node >=22, the same as firebase-admin@14), once it passes your test suite.

Describe alternatives you've considered

  • npm overrides forcing Storage 9: it works around the warning, but it runs the app on a Storage major the SDK hasn't been tested against.
  • emitter.setMaxListeners() / --no-warnings: these hide the symptom and also hide real listener leaks.

Additional context

  • firebase-admin 14.5.0 / 14.5.1, @google-cloud/storage 8.4.0, teeny-request 11.1.1, Node.js 24.
  • We've seen it both in production (Cloud Run, Node 24) and against the Firebase Storage emulator.
Dominant language
TypeScript
Stars
1.8k
Forks
429
Avg merge
4d 19h
Merged PRs (30d)
14

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from firebase/firebase-admin-node

All issues in firebase/firebase-admin-node

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.