Avoid false unavailable warnings for file-scope lexical subs

Open
#2,165 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
java, perl
Domain
backend, frontend

Research direction

Start with the warning condition in src/main/java/org/perlonjava/frontend/parser/SubroutineParser.java near the lexicalSubStorageName check, which emits the unavailable-lexical-sub warning for named subs. Run the minimal reproducer with ./jperl and ./jperl --interpreter to confirm the false warning. Done means that output is just 1 on both backends, a regression test covers file-scope lexical subs, and true out-of-scope diagnostics still fire.

Written by the indexing model from the issue text.

Description

area:parser area:warnings bug

Summary

PerlOnJava emits a false Subroutine "&NAME" is not available closure warning when a package named sub calls a file-scope lexical sub. The lexical sub remains available and the call succeeds, but the warning makes callers that capture warnings fail. This affects both the JVM and interpreter backends.

Minimal reproducer

use feature 'lexical_subs';
no warnings 'experimental::lexical_subs';
use warnings;

my sub helper { 1 }
sub package_sub { helper() }
print package_sub(), "\n";

System Perl prints 1 without a closure warning. PerlOnJava prints Subroutine "&helper" is not available at -e line 1. and then prints 1. This reproduces on both ./jperl and ./jperl --interpreter.

Root cause

src/main/java/org/perlonjava/frontend/parser/SubroutineParser.java emits the unavailable-lexical-sub warning while constructing a named sub when it finds a referenced lexical sub in the outer symbol table. The warning condition checks that the current sub has a name and that the lexical sub is referenced, but it does not distinguish a file-scope lexical sub from a lexical sub whose lifetime is tied to an enclosing runtime invocation. The file-scope case is valid and must not warn.

The reproducer still invokes the lexical sub and returns the expected value; the defect is the warning classification. The current behavior is visible around the lexicalSubStorageName check in SubroutineParser (master source at report time: 506371c134837d026687b1958c856edb3c6f70e4).

CPAN evidence

  • Distribution: Perl-Critic-Policy-ControlStructures-ProhibitEmptyConditionalBlocks 0.001
  • CPAN random run: 20261121-154046-78188
  • Failing test: t/main.t, Test::Warnings assertion no (unexpected) warnings (via done_testing); 1 of 30 tests failed.
  • The captured warnings came from valid file-scope lexical subs in Perl's bundled _charnames.pm: populate_txt, alias, and alias_file.
  • The archived system-Perl oracle used Perl 5.42.2 and passed the target distribution's full suite: 18 files, 30 tests.
  • The current local reproducer was also checked on system Perl 5.34.1, where it prints 1 without a warning. The local PerlOnJava checkout is commit 506371c134837d026687b1958c856edb3c6f70e4, Java 24.0.2, macOS 26.7.3 arm64.

Related issue

Issue #1511 reports the same warning text in a Moo role-composition scenario, but its confirmed cause was caller-package propagation through generated eval and dynamic require. This report is an independent warning defect: it reproduces without Moo or role composition and with a plain file-scope lexical sub.

Acceptance criteria

  • The minimal reproducer prints 1 without warnings on both PerlOnJava backends.
  • A focused project-owned regression test covers file-scope lexical subs referenced from named package subs and is validated with system Perl first.
  • The CPAN distribution's t/main.t warning assertion passes on both backends.
  • Existing diagnostics for lexical subs that truly cannot outlive an enclosing runtime scope remain intact.
Dominant language
Perl
Stars
67
Forks
8
Avg merge
4h 36m
Merged PRs (30d)
123

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fglock/PerlOnJava

All issues in fglock/PerlOnJava

Similar issues

More Perl issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.