Avoid false unavailable warnings for file-scope lexical subs

Offen
#2,165 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
java, perl
Bereich
backend, frontend

Rechercherichtung

Start with the warning condition in src/main/java/org/perlonjava/frontend/parser/SubroutineParser.java near the lexicalSubStorageName check, which emits the unavailable-lexical-sub warning for named subs. Run the minimal reproducer with ./jperl and ./jperl --interpreter to confirm the false warning. Done means that output is just 1 on both backends, a regression test covers file-scope lexical subs, and true out-of-scope diagnostics still fire.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:parser area:warnings bug

Summary

PerlOnJava emits a false Subroutine "&NAME" is not available closure warning when a package named sub calls a file-scope lexical sub. The lexical sub remains available and the call succeeds, but the warning makes callers that capture warnings fail. This affects both the JVM and interpreter backends.

Minimal reproducer

use feature 'lexical_subs';
no warnings 'experimental::lexical_subs';
use warnings;

my sub helper { 1 }
sub package_sub { helper() }
print package_sub(), "\n";

System Perl prints 1 without a closure warning. PerlOnJava prints Subroutine "&helper" is not available at -e line 1. and then prints 1. This reproduces on both ./jperl and ./jperl --interpreter.

Root cause

src/main/java/org/perlonjava/frontend/parser/SubroutineParser.java emits the unavailable-lexical-sub warning while constructing a named sub when it finds a referenced lexical sub in the outer symbol table. The warning condition checks that the current sub has a name and that the lexical sub is referenced, but it does not distinguish a file-scope lexical sub from a lexical sub whose lifetime is tied to an enclosing runtime invocation. The file-scope case is valid and must not warn.

The reproducer still invokes the lexical sub and returns the expected value; the defect is the warning classification. The current behavior is visible around the lexicalSubStorageName check in SubroutineParser (master source at report time: 506371c134837d026687b1958c856edb3c6f70e4).

CPAN evidence

  • Distribution: Perl-Critic-Policy-ControlStructures-ProhibitEmptyConditionalBlocks 0.001
  • CPAN random run: 20261121-154046-78188
  • Failing test: t/main.t, Test::Warnings assertion no (unexpected) warnings (via done_testing); 1 of 30 tests failed.
  • The captured warnings came from valid file-scope lexical subs in Perl's bundled _charnames.pm: populate_txt, alias, and alias_file.
  • The archived system-Perl oracle used Perl 5.42.2 and passed the target distribution's full suite: 18 files, 30 tests.
  • The current local reproducer was also checked on system Perl 5.34.1, where it prints 1 without a warning. The local PerlOnJava checkout is commit 506371c134837d026687b1958c856edb3c6f70e4, Java 24.0.2, macOS 26.7.3 arm64.

Related issue

Issue #1511 reports the same warning text in a Moo role-composition scenario, but its confirmed cause was caller-package propagation through generated eval and dynamic require. This report is an independent warning defect: it reproduces without Moo or role composition and with a plain file-scope lexical sub.

Acceptance criteria

  • The minimal reproducer prints 1 without warnings on both PerlOnJava backends.
  • A focused project-owned regression test covers file-scope lexical subs referenced from named package subs and is validated with system Perl first.
  • The CPAN distribution's t/main.t warning assertion passes on both backends.
  • Existing diagnostics for lexical subs that truly cannot outlive an enclosing runtime scope remain intact.
Vorherrschende Sprache
Perl
Sterne
67
Forks
8
Ø Merge
4 Std. 36 Min.
Gemergte PRs (30 T.)
123

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus fglock/PerlOnJava

Alle Issues in fglock/PerlOnJava

Ähnliche Issues

Weitere Issues zu Perl

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.