Security: local HTTP API is unauthenticated with wildcard CORS — any webpage can load configs, launch or delete files and read disk
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- python
- Domain
- api, authentication, backend, security
Research direction
Begin at src/profiles/server/app.py:40-46 to replace wildcard CORS with the UI origin and add Host-header validation. Reuse the instance_token from routes/instance.py:29-39 as a bearer on all /api routes, including routes/config.py and routes/actions.py. Done means every non-instance API requires the token, CORS denies foreign origins, and server binds loopback by default.
Written by the indexing model from the issue text.
Description
Summary
Everything except /api/instance/* is served with no authentication, and CORSMiddleware is configured with allow_origins=["*"] and allow_credentials=True (src/profiles/server/app.py:40-46). With that combination Starlette echoes any requesting origin back with Access-Control-Allow-Credentials: true, so any page open in any browser on the user's machine can send POSTs to http://127.0.0.1:8088/api/... and read the responses. There is no CSRF token, no same-origin check, and no Host header validation anywhere (the only header check in the codebase is the handoff token in routes/instance.py:29-39).
Drive-by chain (no user interaction beyond visiting a webpage while ProFiles runs)
POST /api/config/load-content(src/profiles/server/routes/config.py:160-188) uploads raw YAML content that becomes the live config after schema validation only. Confighooks:entries are arbitrary shell commands (see the companion shell=True issue).POST /api/actions/launch(src/profiles/server/routes/actions.py:113-134) accepts any directory/filename pair and runs the matching workflow.POST /api/actions/delete(routes/actions.py:164-176→src/profiles/core/actions.py:357-406) deletes any file on disk — "confirmation" is client-side only; a drive-by client simply lies.POST /api/actions/launch-with-args,/open-folder,/open-terminal,/reveal,/hash,/metadataaccept absolute paths with no scoping;GET /api/fs/browse(routes/fs.py:33-67) lists any directory on any drive;GET /api/configandGET /api/systemleak scan directories, username, hostname and IP.- On
--server-onlythe server binds0.0.0.0(src/profiles/app.py:262) — everything above is then reachable by any LAN device with zero auth.
Additionally there is no Host-header check, so DNS rebinding bypasses any CORS-only fix.
Suggested fix
- Require the existing
instance_token(already generated per-instance and used by/api/instance/*) as a bearer token on all/apiroutes; the web client is served by the same server and can receive it at bootstrap. - Set
allow_originsto the actual UI origin instead of["*"]+ credentials. - Validate the
Hostheader (accept only127.0.0.1:<port>/localhost:<port>) — this also closes DNS rebinding. - Keep the default bind on loopback; if LAN sharing via
--server-onlystays a feature, gate it behind the token or an explicit opt-in flag.
Severity: HIGH. Compounding factor: a forced config load turns into command execution via the workflow shell=True issue.
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 4h 46m
- Merged PRs (30d)
- 55
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from falbany/ProFiles
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
falbany/ProFiles#187 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in falbany/ProFiles
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ip-tools/patzilla#219 · 2 comments ·
Maintainers usually reply within 1 day
-
EPSSClient commits to its SQLite cache once per score: a 100-CVE bulk fetch makes 101 disk flushesOpenpriority:p3 technical-debt
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jimmy058910/jmo-security-repo#1673 ·
Maintainers usually reply within 1 day
-
enhancement ready
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
integration: frontier_silicon
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
home-assistant/core#193176 · 2 comments ·
Maintainers usually reply within 1 day
-
task create and task update take --body-file and --stdinPossibly taken @JuanBarriosS claimed this today. Opencli enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
pyrite-wiki/pyrite#1687 · 1 comment ·
Maintainers usually reply within 1 day