Security: local HTTP API is unauthenticated with wildcard CORS — any webpage can load configs, launch or delete files and read disk

Abierto
#26 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python

Línea de trabajo

Begin at src/profiles/server/app.py:40-46 to replace wildcard CORS with the UI origin and add Host-header validation. Reuse the instance_token from routes/instance.py:29-39 as a bearer on all /api routes, including routes/config.py and routes/actions.py. Done means every non-instance API requires the token, CORS denies foreign origins, and server binds loopback by default.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug security

Summary

Everything except /api/instance/* is served with no authentication, and CORSMiddleware is configured with allow_origins=["*"] and allow_credentials=True (src/profiles/server/app.py:40-46). With that combination Starlette echoes any requesting origin back with Access-Control-Allow-Credentials: true, so any page open in any browser on the user's machine can send POSTs to http://127.0.0.1:8088/api/... and read the responses. There is no CSRF token, no same-origin check, and no Host header validation anywhere (the only header check in the codebase is the handoff token in routes/instance.py:29-39).

Drive-by chain (no user interaction beyond visiting a webpage while ProFiles runs)

  1. POST /api/config/load-content (src/profiles/server/routes/config.py:160-188) uploads raw YAML content that becomes the live config after schema validation only. Config hooks: entries are arbitrary shell commands (see the companion shell=True issue).
  2. POST /api/actions/launch (src/profiles/server/routes/actions.py:113-134) accepts any directory/filename pair and runs the matching workflow.
  3. POST /api/actions/delete (routes/actions.py:164-176 → src/profiles/core/actions.py:357-406) deletes any file on disk — "confirmation" is client-side only; a drive-by client simply lies.
  4. POST /api/actions/launch-with-args, /open-folder, /open-terminal, /reveal, /hash, /metadata accept absolute paths with no scoping; GET /api/fs/browse (routes/fs.py:33-67) lists any directory on any drive; GET /api/config and GET /api/system leak scan directories, username, hostname and IP.
  5. On --server-only the server binds 0.0.0.0 (src/profiles/app.py:262) — everything above is then reachable by any LAN device with zero auth.

Additionally there is no Host-header check, so DNS rebinding bypasses any CORS-only fix.

Suggested fix

  • Require the existing instance_token (already generated per-instance and used by /api/instance/*) as a bearer token on all /api routes; the web client is served by the same server and can receive it at bootstrap.
  • Set allow_origins to the actual UI origin instead of ["*"] + credentials.
  • Validate the Host header (accept only 127.0.0.1:<port> / localhost:<port>) — this also closes DNS rebinding.
  • Keep the default bind on loopback; if LAN sharing via --server-only stays a feature, gate it behind the token or an explicit opt-in flag.

Severity: HIGH. Compounding factor: a forced config load turns into command execution via the workflow shell=True issue.

Lenguaje dominante
Python
Estrellas
1
Forks
1
Merge medio
4 h 46 min
PR fusionados (30 d)
55

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de falbany/ProFiles

Todos los issues de falbany/ProFiles

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.