config: inheritance semantics — explicit empty lists can't clear inherited lists, cycle error messages report a wrong chain, template doc mismatches scan/match
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
Research direction
Start with inheritance.py, validator.py, and template.py at the locations named in the issue, then read the related tests for config resolution, cycle validation, and template documentation. Check how explicit empty lists, recursive cycle paths, and scan/match selection currently behave. Done means all three reported defects are addressed, with a regression test asserting the message for a three-node cycle.
Written by the indexing model from the issue text.
Description
Problem
Three related inheritance defects (all verified):
-
Empty lists can't clear. A child config with
extensions: []underextends: baseresolves to the base's list —_merge_str(inheritance.py:20-28) appends base items to the empty local list, and line 107 additionally mergesdefaults.extensionsunconditionally, so a config can never have fewer extensions than defaults. Either honor an explicitly-set empty list as "clear" (distinguishmodel_fields_setfromis None— the machinery is already there) or document the merge-only semantics per field. -
Wrong cycle chains in error messages. For
A→B→A,validator.collect_issuesreportsinheritance cycle: A -> A -> B -> Aandresolve_configsreportsconfigs.B.extends: inheritance cycle: A -> A -> A; forA→B→C→Athe validator saysA -> A -> B -> C -> Awhile inheritance saysA -> A -> B -> A(the config where the cycle closed is missing). Root cause in both files: the stack is seeded(name,)and the recursion appendsnameagain —validator.py:61-85andinheritance.py:55. Fix: seed the initial call with an empty tuple; add a regression test asserting the message for a 3-node cycle. -
Template doc overstates merging.
template.py:323-324claims "lists are merged: local items first, then inherited items not already present" — butscanandmatchare replaced, not merged (inheritance.py:75-85,pick_scan/pick_match). Fix the doc to state per-field: "extensions/filters/row_colors/excludes merge; scan/match replace".
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 4h 46m
- Merged PRs (30d)
- 55
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from falbany/ProFiles
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
falbany/ProFiles#187 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in falbany/ProFiles
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ip-tools/patzilla#219 · 2 comments ·
Maintainers usually reply within 1 day
-
EPSSClient commits to its SQLite cache once per score: a 100-CVE bulk fetch makes 101 disk flushesOpenpriority:p3 technical-debt
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jimmy058910/jmo-security-repo#1673 ·
Maintainers usually reply within 1 day
-
enhancement ready
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
integration: frontier_silicon
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
home-assistant/core#193176 · 2 comments ·
Maintainers usually reply within 1 day
-
task create and task update take --body-file and --stdinPossibly taken @JuanBarriosS claimed this today. Opencli enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
pyrite-wiki/pyrite#1687 · 1 comment ·
Maintainers usually reply within 1 day