config: inheritance semantics — explicit empty lists can't clear inherited lists, cycle error messages report a wrong chain, template doc mismatches scan/match

Abierto
#145 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
backend

Línea de trabajo

Start with inheritance.py, validator.py, and template.py at the locations named in the issue, then read the related tests for config resolution, cycle validation, and template documentation. Check how explicit empty lists, recursive cycle paths, and scan/match selection currently behave. Done means all three reported defects are addressed, with a regression test asserting the message for a three-node cycle.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

code-quality

Problem

Three related inheritance defects (all verified):

  1. Empty lists can't clear. A child config with extensions: [] under extends: base resolves to the base's list — _merge_str (inheritance.py:20-28) appends base items to the empty local list, and line 107 additionally merges defaults.extensions unconditionally, so a config can never have fewer extensions than defaults. Either honor an explicitly-set empty list as "clear" (distinguish model_fields_set from is None — the machinery is already there) or document the merge-only semantics per field.

  2. Wrong cycle chains in error messages. For A→B→A, validator.collect_issues reports inheritance cycle: A -> A -> B -> A and resolve_configs reports configs.B.extends: inheritance cycle: A -> A -> A; for A→B→C→A the validator says A -> A -> B -> C -> A while inheritance says A -> A -> B -> A (the config where the cycle closed is missing). Root cause in both files: the stack is seeded (name,) and the recursion appends name again — validator.py:61-85 and inheritance.py:55. Fix: seed the initial call with an empty tuple; add a regression test asserting the message for a 3-node cycle.

  3. Template doc overstates merging. template.py:323-324 claims "lists are merged: local items first, then inherited items not already present" — but scan and match are replaced, not merged (inheritance.py:75-85, pick_scan/pick_match). Fix the doc to state per-field: "extensions/filters/row_colors/excludes merge; scan/match replace".

Lenguaje dominante
Python
Estrellas
1
Forks
1
Merge medio
4 h 46 min
PR fusionados (30 d)
55

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de falbany/ProFiles

Todos los issues de falbany/ProFiles

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.