server: hatch build hook only watches package.json — wheel builds ship a stale frontend after source-only edits

Open
#136 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active

Research direction

Start by reading src/profiles/web/build_hook.py and build.py, then compare how each build path decides whether to rebuild, installs dependencies, and reports failures. The issue points to the relevant functions and proposed fixes. Done means source or lockfile edits trigger fresh wheel assets, both paths handle npm consistently, and hook failures show useful error output.

Written by the indexing model from the issue text.

Description

bug code-quality

Problem

The packaging staleness check ignores every frontend source file:

# src/profiles/web/build_hook.py:17-28
def _needs_rebuild(web_dir: Path, marker_file: Path) -> bool:
    if not marker_file.exists():
        return True
    package_json = web_dir / "package.json"
    …
    return package_mtime > marker_mtime

Editing any .ts/.tsx/.css source after the last build and running hatch build / pip install . skips the rebuild entirely and packages the committed dist/ (possibly stale).

Related divergence between the two build paths (DRY violation per AGENTS.md):

  • build.py:141-149 deliberately runs npm install ("Use npm install instead of npm ci to handle lock file sync issues") — which can silently mutate package-lock.json during a "build" — while the hook runs npm ci. build.py also doesn't watch package-lock.json for staleness.
  • build_hook._run_npm_build uses capture_output=True and on failure prints only ERROR: npm build failed: {e} (build_hook.py:74-76) — e.stdout/e.stderr are discarded, so a failed packaging build gives no reason.

Suggested fix

  1. Extract a shared needs_rebuild() into web/build.py (scanning package.json + lock + **/*.{ts,tsx,css,html}) and have build_hook import it — or simply always run npm run build in the hook when npm is available.
  2. Standardize on npm ci --no-audit --no-fund in both (escape-hatch flag for lock drift in build.py).
  3. Print e.stderr (tail) on hook failure.
Dominant language
Python
Stars
1
Forks
1
Avg merge
4h 46m
Merged PRs (30d)
55

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from falbany/ProFiles

All issues in falbany/ProFiles

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.