server: hatch build hook only watches package.json — wheel builds ship a stale frontend after source-only edits

未关闭
#136 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
68/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃

调研方向

Start by reading src/profiles/web/build_hook.py and build.py, then compare how each build path decides whether to rebuild, installs dependencies, and reports failures. The issue points to the relevant functions and proposed fixes. Done means source or lockfile edits trigger fresh wheel assets, both paths handle npm consistently, and hook failures show useful error output.

由索引模型根据 Issue 内容生成。

描述

bug code-quality

Problem

The packaging staleness check ignores every frontend source file:

# src/profiles/web/build_hook.py:17-28
def _needs_rebuild(web_dir: Path, marker_file: Path) -> bool:
    if not marker_file.exists():
        return True
    package_json = web_dir / "package.json"
    …
    return package_mtime > marker_mtime

Editing any .ts/.tsx/.css source after the last build and running hatch build / pip install . skips the rebuild entirely and packages the committed dist/ (possibly stale).

Related divergence between the two build paths (DRY violation per AGENTS.md):

  • build.py:141-149 deliberately runs npm install ("Use npm install instead of npm ci to handle lock file sync issues") — which can silently mutate package-lock.json during a "build" — while the hook runs npm ci. build.py also doesn't watch package-lock.json for staleness.
  • build_hook._run_npm_build uses capture_output=True and on failure prints only ERROR: npm build failed: {e} (build_hook.py:74-76) — e.stdout/e.stderr are discarded, so a failed packaging build gives no reason.

Suggested fix

  1. Extract a shared needs_rebuild() into web/build.py (scanning package.json + lock + **/*.{ts,tsx,css,html}) and have build_hook import it — or simply always run npm run build in the hook when npm is available.
  2. Standardize on npm ci --no-audit --no-fund in both (escape-hatch flag for lock drift in build.py).
  3. Print e.stderr (tail) on hook failure.
主要语言
Python
星标
1
派生
1
平均合并
4 小时 46 分钟
30 天内合并 PR
55

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

falbany/ProFiles 的其他 Issue

查看 falbany/ProFiles 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。