config: match.ip is never evaluated and match.path never during auto-selection — documented selection criteria silently ignored
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start with src/profiles/core/config/service.py and trace the three select_active_configuration calls named in the issue, then read matcher.py, models.py, and the template examples. Check how get_local_ip() and the working directory are obtained and how path matching is intended to work; the issue leaves the path behavior as a design choice. Done means documented IP and path criteria work as described, or the docs and examples accurately describe the supported behavior, with tests covering the chosen behavior.
Written by the indexing model from the issue text.
Description
Problem
Every production caller of select_active_configuration hardcodes empty IP and path candidates:
# src/profiles/core/config/service.py:107, 160, 196 — all three
return select_active_configuration(config, hostname, "", "")
And match_pattern returns False when the value is empty (matcher.py:25-26), so match.ip and match.path criteria can never match:
get_local_ip()exists (src/profiles/utils/network.py:32, used bycollect_system_info) but is never plumbed into matching.- The starter template advertises IP matching with a worked example (
template.py:337-343and the commentedproductionconfig, lines 356-373). MatchCriteria.pathis documented as "Glob patterns for paths that must exist on the filesystem" (models.py:163-165) — yet nothing verifies existence; path patterns only participate in post-selection directory matching viafind_active_config(service.py:69-71).
Net effect: a user who writes an ip: or path: match criterion silently gets the fallback config, with no diagnostic anywhere.
Suggested fix
- Pass
get_local_ip()(and a working-directory candidate) intoselect_active_configurationfromfind_configuration_by_hostname/auto_select_directory/choose_active_directory. - For
path, either implement existence semantics inmatches_machine_config(fnmatch each pattern against existing scan/cwd paths) or fix the docstring to state the caller must supply the path — and drop the misleading template example if the feature is not implemented.
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 4h 46m
- Merged PRs (30d)
- 55
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from falbany/ProFiles
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
falbany/ProFiles#187 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in falbany/ProFiles
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ip-tools/patzilla#219 · 2 comments ·
Maintainers usually reply within 1 day
-
EPSSClient commits to its SQLite cache once per score: a 100-CVE bulk fetch makes 101 disk flushesOpenpriority:p3 technical-debt
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jimmy058910/jmo-security-repo#1673 ·
Maintainers usually reply within 1 day
-
enhancement ready
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
integration: frontier_silicon
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
home-assistant/core#193176 · 2 comments ·
Maintainers usually reply within 1 day
-
task create and task update take --body-file and --stdinPossibly taken @JuanBarriosS claimed this today. Opencli enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
pyrite-wiki/pyrite#1687 · 1 comment ·
Maintainers usually reply within 1 day