config: match.ip is never evaluated and match.path never during auto-selection — documented selection criteria silently ignored

Open
#120 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
backend

Research direction

Start with src/profiles/core/config/service.py and trace the three select_active_configuration calls named in the issue, then read matcher.py, models.py, and the template examples. Check how get_local_ip() and the working directory are obtained and how path matching is intended to work; the issue leaves the path behavior as a design choice. Done means documented IP and path criteria work as described, or the docs and examples accurately describe the supported behavior, with tests covering the chosen behavior.

Written by the indexing model from the issue text.

Description

bug

Problem

Every production caller of select_active_configuration hardcodes empty IP and path candidates:

# src/profiles/core/config/service.py:107, 160, 196 — all three
return select_active_configuration(config, hostname, "", "")

And match_pattern returns False when the value is empty (matcher.py:25-26), so match.ip and match.path criteria can never match:

  • get_local_ip() exists (src/profiles/utils/network.py:32, used by collect_system_info) but is never plumbed into matching.
  • The starter template advertises IP matching with a worked example (template.py:337-343 and the commented production config, lines 356-373).
  • MatchCriteria.path is documented as "Glob patterns for paths that must exist on the filesystem" (models.py:163-165) — yet nothing verifies existence; path patterns only participate in post-selection directory matching via find_active_config (service.py:69-71).

Net effect: a user who writes an ip: or path: match criterion silently gets the fallback config, with no diagnostic anywhere.

Suggested fix

  1. Pass get_local_ip() (and a working-directory candidate) into select_active_configuration from find_configuration_by_hostname / auto_select_directory / choose_active_directory.
  2. For path, either implement existence semantics in matches_machine_config (fnmatch each pattern against existing scan/cwd paths) or fix the docstring to state the caller must supply the path — and drop the misleading template example if the feature is not implemented.
Dominant language
Python
Stars
1
Forks
1
Avg merge
4h 46m
Merged PRs (30d)
55

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from falbany/ProFiles

All issues in falbany/ProFiles

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.