config: match.ip is never evaluated and match.path never during auto-selection — documented selection criteria silently ignored

Abierto
#120 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
backend

Línea de trabajo

Start with src/profiles/core/config/service.py and trace the three select_active_configuration calls named in the issue, then read matcher.py, models.py, and the template examples. Check how get_local_ip() and the working directory are obtained and how path matching is intended to work; the issue leaves the path behavior as a design choice. Done means documented IP and path criteria work as described, or the docs and examples accurately describe the supported behavior, with tests covering the chosen behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Problem

Every production caller of select_active_configuration hardcodes empty IP and path candidates:

# src/profiles/core/config/service.py:107, 160, 196 — all three
return select_active_configuration(config, hostname, "", "")

And match_pattern returns False when the value is empty (matcher.py:25-26), so match.ip and match.path criteria can never match:

  • get_local_ip() exists (src/profiles/utils/network.py:32, used by collect_system_info) but is never plumbed into matching.
  • The starter template advertises IP matching with a worked example (template.py:337-343 and the commented production config, lines 356-373).
  • MatchCriteria.path is documented as "Glob patterns for paths that must exist on the filesystem" (models.py:163-165) — yet nothing verifies existence; path patterns only participate in post-selection directory matching via find_active_config (service.py:69-71).

Net effect: a user who writes an ip: or path: match criterion silently gets the fallback config, with no diagnostic anywhere.

Suggested fix

  1. Pass get_local_ip() (and a working-directory candidate) into select_active_configuration from find_configuration_by_hostname / auto_select_directory / choose_active_directory.
  2. For path, either implement existence semantics in matches_machine_config (fnmatch each pattern against existing scan/cwd paths) or fix the docstring to state the caller must supply the path — and drop the misleading template example if the feature is not implemented.
Lenguaje dominante
Python
Estrellas
1
Forks
1
Merge medio
4 h 46 min
PR fusionados (30 d)
55

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de falbany/ProFiles

Todos los issues de falbany/ProFiles

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.