windows-artifacts: the win-arm64 job uses a Visual Studio generator missing from windows-11-arm

Open Beginner friendly
#4,996 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
86/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
c, cmake, github-actions

Research direction

Read windows-artifacts.yml and compare the win-arm64 CMake generator with the one already used in cmake-tests.yml. Change it to match, then verify with a push to test_artifacts as the issue requests. Done means the win-arm64 job configures successfully with the runner's installed Visual Studio.

Written by the indexing model from the issue text.

Description

The win-arm64 job of windows-artifacts.yml configures CMake with -G "Visual Studio 17 2022", but the windows-11-arm image now ships only Visual Studio 2026. The last run of this workflow (run 44396122729, 2026-11-18) fails at configuration:

CMake Error at CMakeLists.txt:30 (project):
  Generator

    Visual Studio 17 2022

  could not find any instance of Visual Studio.

cmake-tests.yml was already switched to Visual Studio 18 2026 for the same runner in 2c2a6216e, but windows-artifacts.yml was not.

This workflow only runs on pushes to test_artifacts, win_artifacts and release, and on published releases, so the failure would first show up at the next release. With the default fail-fast, it also cancels the win32 and win64 jobs (as in run 43975850626), so that release could ship without any Windows package.

Fix: use the same generator as cmake-tests.yml, and check with a push to test_artifacts. Running this workflow on PRs that touch lib/dll/example/ or the workflow itself would catch this kind of breakage earlier.

Related: #4395.

Dominant language
C
Stars
28.1k
Forks
2.7k
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from facebook/zstd

All issues in facebook/zstd

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.